FFe for the lp:~ilidrissi.amine/software-center/addons branch

[Michael Vogt]

Binary package hint: software-center

Hi,

the above branch implements the handling of addon packages (Enhance, Recommends-that-are-not-already-installed, Suggests). It would be nice to consider it for maverick. It pretty straightforward, the only risk is that there are some new apt cache operations that can make the page slower. But in the worst case, we can disable it relatively easily, its quite isolated.

Thanks,
 Michael

[Scott Kitterman (kitterman)]

Maybe it's just me, but I don't see a link to the branch. Would you please provide the link in a comment.

[Michael Vogt (mvo)]

Ups, I'm very sorry, the branch name is in the title, but that is obviously not good, here is a proper link:
https://code.edge.launchpad.net/~ilidrissi.amine/software-center/addons

thanks,
 Michael

[Michael Vogt (mvo)]

Here is the link with the merge request to get a idea about the scope:
https://code.edge.launchpad.net/~ilidrissi.amine/software-center/addons/+merge/30946

[Scott Kitterman (kitterman)]

Thanks.

The 5 new FIXME comments are interesting. Why is that OK? The ones on lines
313 and 353 of the diff seem most interesting.

[Mohamed Amine Ilidrissi (ilidrissi.amine)]

You mean, the "FIXME: figure out why I have to call this function two times to get rid of important packages"? In fact, I don't know why this is necessary (needs investigating), but since it does the job and doesn't affect negatively the other bits, I don't think it would be a problem (tell me if this explanation is inappropriate).

[Scott Kitterman (kitterman)]

Ack. Approved, but the fixme does cause me some doubt about is this the correct approach.

[Kiwinote (kiwinote)]

This branch was merged last week.