Mahara

lang string 'phpversion' contains incorrect version of php

Bug #617187 reported by John Kelsh on 2010-08-13

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Mahara	Fix Released	Low	Andrew Nicols	Mahara 1.3.0

Bug Description

In the daily build of Mahara the ensure_sanity function checks that the current PHP version is 5.2 or greater.

If it is not the phpversion string is displayed, which still indicates PHP 5.1.2 or greater.

Revision history for this message

John Kelsh (jkelsh) wrote on 2010-08-13:

phpversion_lang.patch Edit (1.3 KiB, text/plain)

Andrew Nicols (dobedobedoh) on 2010-08-13

Changed in mahara:
importance:	Undecided → Low
status:	New → Confirmed
milestone:	none → 1.3.0
assignee:	nobody → Andrew Robert Nicols (dobedobedoh)

Revision history for this message

Andrew Nicols (dobedobedoh) wrote on 2010-08-13:

Hi John,

Thanks for the bug report and the patch. Rather than simply changing the version in the language string, I've passed the required version of php to get_string in the ensure_sanity() function of lib/mahara.php. This has the advantage that it can't get out of sync again as we're testing the same version number that we're passing. If you're interested, it commit
72d12ea829798e8d7f3f446a9070dc4f32fd8ecd of master.

This change won't fix non-english langauge files as these are distributed seperately.