on upgrade from 1.6.2, euca_upgrade should preserve DISABLE_ISCSI="Y"

[Daniel Nurmi]

If package upgrade: set DISABLE_ISCSI="Y" in eucalyptus.conf
else (not upgrade): leave default DISABLE_ISCSI="N"

fix is in 'euca_upgrade'

[Clint Byrum (clint-fewbar)]

Marking Triaged, as Daniel seems to be looking at this upstream. Mirroring upstream important of Medium.

[Thierry Carrez (ttx)]

Assigning to Dave to check if this is already fixed

[Dave Walker (davewalker)]

Whilst this particular issue as described has been fixed released in Maverick, if the modification is made to eucalyptus.local.conf the feature is not.

[Dave Walker (davewalker)]

Looking at the code, I am a little confused with how it compares to the bug report. I believe this is the part that resolves this bug:
sed -i "s/DISABLE_ISCSI=\"N\"/DISABLE_ISCSI=\"Y\"/" ${NEW_EUCA}/etc/eucalyptus/eucalyptus.conf

It looks to me that it is changing the default (forcing "Y"), not preserving DISABLE_ISCSI=Y. Have i misunderstood the segment that fixes this bug?

[Dmitrii Zagorodnov (dmitrii)]

You are right that we don't "preserve" the actual setting, but rather "preserve" the use of AoE for EBS if you are upgrading instead of forcing you to switch to iSCSI, which is the default for a fresh 2.0 installation. That `sed` statement, which is only executed if you are upgrading, essentially changes the 2.0 default back to 1.6.2 default.

[Dave Walker (davewalker)]

Based on Dmitrii's comment, this is fix released. Thanks for wrapping that up.