(OXFAM Prod) Duplicate Page Title in Wiki

Bug #616790 reported by Jim B. Glenn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KARL3
Fix Released
Low
Carlos de la Guardia

Bug Description

reported via error_monitor

ENTRY
Thu Aug 12 06:59:50 2010
Exception when processing https://karl.oxfam.org.uk/communities/sru2/wiki/partner-tax-special/edit.html
Traceback (most recent call last):
  File "/opt/karl/oxfam/3.5-0/src/karl/karl/errorlog.py", line 15, in middleware
    return app(environ, start_response)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.zodbconn-0.11-py2.5.egg/repoze/zodbconn/connector.py", line 21, in __call__
    result = self.next_app(environ, start_response)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.retry-0.9.4-py2.5.egg/repoze/retry/__init__.py", line 88, in __call__
    app_iter = self.application(environ, replace_start_response)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.tm2-1.0a5-py2.5.egg/repoze/tm/__init__.py", line 23, in __call__
    result = self.application(environ, save_status_and_headers)
  File "/opt/karl/oxfam/3.5-0/eggs/Paste-1.7.2-py2.5.egg/paste/registry.py", line 350, in __call__
    app_iter = self.application(environ, start_response)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.who-1.0.15-py2.5.egg/repoze/who/middleware.py", line 107, in __call__
    app_iter = app(environ, wrapper.wrap_start_response)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.browserid-0.3-py2.5.egg/repoze/browserid/middleware.py", line 127, in __call__
    return self.app(environ, start_response)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.bfg-1.2-py2.5.egg/repoze/bfg/router.py", line 130, in __call__
    response = view_callable(context, request)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.bfg-1.2-py2.5.egg/repoze/bfg/configuration.py", line 1520, in __call__
    return view(context, request)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.bfg-1.2-py2.5.egg/repoze/bfg/configuration.py", line 1805, in attr_view
    return view(context, request)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.bfg-1.2-py2.5.egg/repoze/bfg/configuration.py", line 1738, in predicate_wrapper
    return view(context, request)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.bfg-1.2-py2.5.egg/repoze/bfg/configuration.py", line 1753, in _secured_view
    return view(context, request)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.bfg-1.2-py2.5.egg/repoze/bfg/configuration.py", line 1704, in _rendered_view
    response = view(context, request)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.bfg.formish-0.3-py2.5.egg/repoze/bfg/formish/zcml.py", line 174, in __call__
    return submitted(request, form, controller, self.action, controller)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.bfg.formish-0.3-py2.5.egg/repoze/bfg/formish/zcml.py", line 213, in submitted
    result = getattr(controller, handler)(converted)
  File "/opt/karl/oxfam/3.5-0/src/karl/karl/content/views/wiki.py", line 315, in handle_submit
    context.change_title(newtitle)
  File "/opt/karl/oxfam/3.5-0/src/karl/karl/content/models/wiki.py", line 118, in change_title
    raise ValueError('Duplicate page title "%s"' % title)
ValueError: Duplicate page title "Letters and Special Actions"

Revision history for this message
Paul Everitt (paul-agendaless) wrote :

This made it up to the error monitor. Any chance the form validation should catch it instead? (Put in M46 Low for after this week.)

Changed in karl3:
assignee: nobody → Tres Seaver (tseaver)
importance: Undecided → Low
milestone: none → m46
Revision history for this message
Chris Rossi (chris-archimedeanco) wrote :

Yes, this should probably be caught in the form validation.

Revision history for this message
Carlos de la Guardia (cguardia) wrote :

when a wiki page title was edited and then another wiki page tried to use the new title, the form validator would let this pass, since it was checking the __name__ and not the title. However, the wiki model does check the title, so this resulted in a ValueError exception being thrown. Added a wiki title validator to avoid the exception.

Changed in karl3:
status: New → Fix Committed
assignee: Tres Seaver (tseaver) → Carlos de la Guardia (cguardia)
Revision history for this message
JimPGlenn (jpglenn09) wrote :

fixed

Changed in karl3:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.