(OXFAM Prod) Duplicate Page Title in Wiki

[Jim B. Glenn]

reported via error_monitor

ENTRY
Thu Aug 12 06:59:50 2010
Exception when processing https://karl.oxfam.org.uk/communities/sru2/wiki/partner-tax-special/edit.html
Traceback (most recent call last):
  File "/opt/karl/oxfam/3.5-0/src/karl/karl/errorlog.py", line 15, in middleware
    return app(environ, start_response)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.zodbconn-0.11-py2.5.egg/repoze/zodbconn/connector.py", line 21, in __call__
    result = self.next_app(environ, start_response)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.retry-0.9.4-py2.5.egg/repoze/retry/__init__.py", line 88, in __call__
    app_iter = self.application(environ, replace_start_response)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.tm2-1.0a5-py2.5.egg/repoze/tm/__init__.py", line 23, in __call__
    result = self.application(environ, save_status_and_headers)
  File "/opt/karl/oxfam/3.5-0/eggs/Paste-1.7.2-py2.5.egg/paste/registry.py", line 350, in __call__
    app_iter = self.application(environ, start_response)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.who-1.0.15-py2.5.egg/repoze/who/middleware.py", line 107, in __call__
    app_iter = app(environ, wrapper.wrap_start_response)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.browserid-0.3-py2.5.egg/repoze/browserid/middleware.py", line 127, in __call__
    return self.app(environ, start_response)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.bfg-1.2-py2.5.egg/repoze/bfg/router.py", line 130, in __call__
    response = view_callable(context, request)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.bfg-1.2-py2.5.egg/repoze/bfg/configuration.py", line 1520, in __call__
    return view(context, request)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.bfg-1.2-py2.5.egg/repoze/bfg/configuration.py", line 1805, in attr_view
    return view(context, request)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.bfg-1.2-py2.5.egg/repoze/bfg/configuration.py", line 1738, in predicate_wrapper
    return view(context, request)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.bfg-1.2-py2.5.egg/repoze/bfg/configuration.py", line 1753, in _secured_view
    return view(context, request)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.bfg-1.2-py2.5.egg/repoze/bfg/configuration.py", line 1704, in _rendered_view
    response = view(context, request)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.bfg.formish-0.3-py2.5.egg/repoze/bfg/formish/zcml.py", line 174, in __call__
    return submitted(request, form, controller, self.action, controller)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.bfg.formish-0.3-py2.5.egg/repoze/bfg/formish/zcml.py", line 213, in submitted
    result = getattr(controller, handler)(converted)
  File "/opt/karl/oxfam/3.5-0/src/karl/karl/content/views/wiki.py", line 315, in handle_submit
    context.change_title(newtitle)
  File "/opt/karl/oxfam/3.5-0/src/karl/karl/content/models/wiki.py", line 118, in change_title
    raise ValueError('Duplicate page title "%s"' % title)
ValueError: Duplicate page title "Letters and Special Actions"

[Paul Everitt (paul-agendaless)]

This made it up to the error monitor. Any chance the form validation should catch it instead? (Put in M46 Low for after this week.)

[Chris Rossi (chris-archimedeanco)]

Yes, this should probably be caught in the form validation.

[Carlos de la Guardia (cguardia)]

when a wiki page title was edited and then another wiki page tried to use the new title, the form validator would let this pass, since it was checking the __name__ and not the title. However, the wiki model does check the title, so this resulted in a ValueError exception being thrown. Added a wiki title validator to avoid the exception.

[JimPGlenn (jpglenn09)]

fixed