Launchpad itself

feature flags need administration UI

Bug #616631 reported by Martin Pool
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Martin Pool
Launchpad itself 10.10

Bug Description

As part of https://dev.launchpad.net/LEP/FeatureFlags we need a web interface that allows admins to edit feature flags.

Related branches

lp:~mbp/launchpad/flags-gui
Jeroen T. Vermeulen (community): Approve (code)
Launchpad code reviewers: Pending requested
Diff: 693 lines (+476/-42)
11 files modified
lib/lp/services/features/__init__.py (+11/-1)
lib/lp/services/features/browser/configure.zcml (+25/-0)
lib/lp/services/features/browser/edit.py (+84/-0)
lib/lp/services/features/browser/tests/test_feature_editor.py (+138/-0)
lib/lp/services/features/configure.zcml (+3/-0)
lib/lp/services/features/flags.py (+19/-29)
lib/lp/services/features/model.py (+1/-0)
lib/lp/services/features/rulesource.py (+116/-0)
lib/lp/services/features/templates/feature-rules.pt (+18/-0)
lib/lp/services/features/tests/test_flags.py (+58/-11)
lib/lp/services/features/webapp.py (+3/-1)
Martin Pool (mbp)
tags: added: feature-flags
Revision history for this message
Martin Pool (mbp) wrote :

In the first cut of this I plan to add a page at https://launchpad.net/+feature-rules that just shows them in a crude text table. After discussion with Robert, I think we will limit it to ~admins and ~launchpad access for read. I still need to work out the right way to hook in that access control.

summary: - need a gui to edit feature flags
+ feature flags need administration UI
Changed in launchpad-foundations:
importance: Medium → High
Revision history for this message
Martin Pool (mbp) wrote :
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r11657 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11657>.

Changed in launchpad-foundations:
milestone: none → 10.10
tags: added: qa-needstesting
Changed in launchpad-foundations:
status: In Progress → Fix Committed
Revision history for this message
Martin Pool (mbp) wrote :

manual testing on edge:

- anonymous access gets you asked to log in
- the form is, incorrectly, writeable when you're not an admin - bug 651852 - but this fails safely and shouldn't block rollout
- still waiting for an admin to help me test write access works

Revision history for this message
Martin Pool (mbp) wrote :

Tom kindly tried adding and deleting rules on edge, so and it worked ok, so I think this is now qa-ok.

tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad-foundations:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.