CSV upload reader gives null byte error

[Jim B. Glenn]

reported via error_monitor

ENTRY
Wed Aug 11 11:28:39 2010
Exception when processing https://karl.oxfam.org.uk/upload_users_csv.html
Traceback (most recent call last):
  File "/opt/karl/oxfam/3.5-0/src/karl/karl/errorlog.py", line 15, in middleware
    return app(environ, start_response)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.zodbconn-0.11-py2.5.egg/repoze/zodbconn/connector.py", line 21, in __call__
    result = self.next_app(environ, start_response)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.retry-0.9.4-py2.5.egg/repoze/retry/__init__.py", line 88, in __call__
    app_iter = self.application(environ, replace_start_response)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.tm2-1.0a5-py2.5.egg/repoze/tm/__init__.py", line 23, in __call__
    result = self.application(environ, save_status_and_headers)
  File "/opt/karl/oxfam/3.5-0/eggs/Paste-1.7.2-py2.5.egg/paste/registry.py", line 350, in __call__
    app_iter = self.application(environ, start_response)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.who-1.0.15-py2.5.egg/repoze/who/middleware.py", line 107, in __call__
    app_iter = app(environ, wrapper.wrap_start_response)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.browserid-0.3-py2.5.egg/repoze/browserid/middleware.py", line 127, in __call__
    return self.app(environ, start_response)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.bfg-1.2-py2.5.egg/repoze/bfg/router.py", line 130, in __call__
    response = view_callable(context, request)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.bfg-1.2-py2.5.egg/repoze/bfg/configuration.py", line 1753, in _secured_view
    return view(context, request)
  File "/opt/karl/oxfam/3.5-0/eggs/repoze.bfg-1.2-py2.5.egg/repoze/bfg/configuration.py", line 1663, in _bfg_class_view
    response = inst()
  File "/opt/karl/oxfam/3.5-0/src/karl/karl/views/admin.py", line 519, in __call__
    rows = list(reader)
  File "/opt/python2.5//lib/python2.5/csv.py", line 85, in next
    row = self.reader.next()
Error: line contains NULL byte

[Chris Rossi (chris-archimedeanco)]

Not sure what someone would be uploading to create this error. (A null byte should never occur in a text file.) Go ahead and make sure we catch exceptions like this, though, and generate form validation errors rather than blow up.

[Paul Everitt (paul-agendaless)]

I'll hand this one over to Carlos to take Chris's suggested step regarding form validation.

[Carlos de la Guardia (cguardia)]

Seems like some old MS-DOS files might do this. Anyway, added exception handling for that case and a proper validation error.

[JimPGlenn (jpglenn09)]

fixed