[5.0] Product change on invoice line

[Quentin THEURET @Amaris]

On invoice line, when you change the product, the UoM and the description aren't updated.

[Quentin THEURET @Amaris (qtheuret)]

I attach a patch for the modification of the UoM when the product change.

For the update of the description, the behavior of the system for sale is to replace the description by the product name on sale order line and on invoice line, the behavior is to no update the description.

Should the behavior be always same ?

[JMA(Open ERP) (jma-openerp)]

Hello Quentin,

Would you please apply this patch and notify us?

Thanks.

[JMA(Open ERP) (jma-openerp)]

We would like to ask our usability experts about what should be the actual behaviour before & after the patch, Experts please guide us.

Thank you.

[Quentin THEURET @Amaris (qtheuret)]

Hello JMA,

You patch works fine when you clear the product_id field. But if you change the product without cleared the field, the problem occurs again.

My patch fix the problem for the UoS but not fix the problem for the description because I wait for the response about the unicity of behavior about lines (in invoice, in order, in purchase, ...)

A combinaison of your patch and my patch fix the problem when clear the field and when modify the product without clear the field before.

[JMA(Open ERP) (jma-openerp)]

Hello Quentin,

Thank you for pointing it out.
Would you please apply the patch and notify us?

Thank you.

[Quentin THEURET @Amaris (qtheuret)]

Hello JMA,

The patch works fine.

Thank you.

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Usability Experts,

I would like request you to share your views here.
This is really an important issue.

1. Do we really require 'name' to pass on onchange_product_id?
2. Same thing applies for uom.

Thanks.

[Ferdinand (office-chricar)]

IMHO changing the product should fetch the values for the new product, regardless what was entered before.
Nevertheless I admit that in some cases the user might have to reenter some data, but in doubt the in the majority of cases fetching the new values will be correct.

I just want to point to the fact that the uom is later stored in the stock_move and I have had already some bad issues having more than ONE uom in stock moves (product_uom) - there are some "group by uom" returning more than one record giving wrong figures.
but that might be another issue that the product_uom must not change over time = it shouldn't be stored in stock_move at all.

[JMA(Open ERP) (jma-openerp)]

Hello Quentin,

Things work pretty well with the latest trunk version.
It has been resolved.
Thanks.