Recipe builds break the world when requester does not have a preferred email address
Bug #614858 reported by
William Grant
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
Tim Penhey | ||
Bug Description
When an attempt to dispatch a recipe build requested by a person without a preferred email address, the following happens:
2010-08-07 23:26:24+0100 [-] startBuild(Lucid, daily, gnome-terminator (on http://
2010-08-07 23:26:24+0100 [-] Scanning failed with: 'NoneType' object has no attribute 'email'
This knocks out the build farm entirely until somebody cancels the problematic builds. This situation can arise in at least a couple of cases: 1) a user requests a build, then deactivates their account; or 2) a team without a contact address owns a recipe which is set to build daily.
This case needs to be handled more gracefully or forbidden.
Related branches
lp:~thumper/launchpad/recipe-build-email-fix
- Julian Edwards (community): Approve (release-critical)
- Robert Collins (community): Approve
-
Diff: 178 lines (+77/-29)2 files modifiedlib/lp/code/model/recipebuilder.py (+8/-2)
lib/lp/code/model/tests/test_recipebuilder.py (+69/-27)
| summary: |
- Recipe builds fail when requester does not have a preferred email - address + Recipe builds break the world when requester does not have a preferred + email address |
| Changed in launchpad-code: | |
| status: | New → Triaged |
| importance: | Undecided → Critical |
| assignee: | nobody → Tim Penhey (thumper) |
| milestone: | none → 10.08 |
| Changed in launchpad-code: | |
| status: | Triaged → In Progress |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad-code: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Tim Penhey (thumper) wrote | #2 |
| tags: |
added: qa-ok removed: qa-needstesting |
| tags: |
added: qa-needstesting removed: qa-ok |
Revision history for this message
| Tom Haddon (mthaddon) wrote | #3 |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r11316 <http://