mysql_alter_db() still pushes a raw SQL statement into the replication stream
Bug #614061 reported by
Brian Aker
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Drizzle |
Fix Released
|
Medium
|
David Shrewsbury | ||
7.0 |
Fix Released
|
Medium
|
David Shrewsbury |
Bug Description
Since mysql_alter_db() pushes raw SQL into the replication stream the end result is something that is not portable. We should either send in a set of change vectors, or just hand over the table and let the client side do a diff.
Related branches
lp:~dshrews/drizzle/bug614061-alter-schema
- Drizzle Developers: Pending requested
-
Diff: 334 lines (+168/-9)12 files modifieddrizzled/db.cc (+4/-3)
drizzled/db.h (+1/-1)
drizzled/message/statement_transform.cc (+41/-0)
drizzled/message/statement_transform.h (+22/-1)
drizzled/statement/alter_schema.cc (+1/-1)
drizzled/transaction_services.cc (+34/-0)
drizzled/transaction_services.h (+14/-0)
plugin/transaction_log/tests/r/alter_schema.result (+5/-0)
plugin/transaction_log/tests/r/transaction_log_schema.result (+27/-2)
plugin/transaction_log/tests/t/alter_schema-master.opt (+1/-0)
plugin/transaction_log/tests/t/alter_schema.test (+17/-0)
plugin/transaction_log/tests/t/check_transaction_log.inc (+1/-1)
Changed in drizzle: | |
assignee: | nobody → Joe Daly (skinny.moey) |
importance: | Undecided → Medium |
status: | New → Confirmed |
Changed in drizzle: | |
assignee: | Joe Daly (skinny.moey) → David Shrewsbury (dshrews) |
Changed in drizzle: | |
status: | Confirmed → In Progress |
To post a comment you must log in.
On Thu, 05 Aug 2010 21:55:04 -0000, Brian Aker <email address hidden> wrote:
> Since mysql_alter_db() pushes raw SQL into the replication stream the
> end result is something that is not portable. We should either send in a
> set of change vectors, or just hand over the table and let the client
> side do a diff.
You can't reliably do a diff for all the ALTER TABLE operations we
support.
e.g. you can drop a column and add a column with the same name.
--
Stewart Smith