EC2Provider.connect() should return sshclient.connect()'s deferred

[Gustavo Niemeyer]

EC2Provider.connect() is currently calling the sshclient.connect() method, and then returning the client itself. It must return the result of sshclient's connect method instead, which is a deferred that once fired will return the client. Without this, there's no way to wait for the connection to complete when using EC2Provider's connect method.

[Kapil Thangavelu (hazmat)]

it already does, not clear what if any issue there is here.

[Gustavo Niemeyer (niemeyer)]

As we've seen over the spike, it doesn't:

    def _connect_nodes(self, nodes):
        if not nodes:
            raise NoConnection("No Ensemble Nodes")

        # TODO Should we pick a random entry from the nodes list?
        client = SSHClient()
        client.connect(nodes[0].dns_name + ":2181")
        return client

It should be:

    return client.connect(...)