A bunch of undefined references in several files detected by pyflakes

[Lorenzo Gil Sanchez]

There are several files with undefined references:

src/saml2/binding.py:46: undefined name 'FORM_SPEC'
src/saml2/binding.py:46: undefined name 'location'
src/saml2/binding.py:46: undefined name 'base64'
src/saml2/binding.py:46: undefined name 'authen_req'
src/saml2/binding.py:47: undefined name 'os'
src/saml2/binding.py:58: undefined name 'urllib'
src/saml2/binding.py:59: undefined name 'deflate_and_base64_encode'
src/saml2/binding.py:60: undefined name 'authen_req'
src/saml2/binding.py:64: undefined name 'location'
src/saml2/binding.py:158: undefined name 'binding'
src/saml2/client.py:415: undefined name 'NameID'
src/saml2/client.py:425: undefined name 'session_id'
src/saml2/saml.py:148: local variable '_x' is assigned to but never used
src/saml2/virtual_org.py:44: undefined name 'environ'
src/saml2/virtual_org.py:51: local variable '_ignore' is assigned to but never used

In the attached patch I fixed most of these errores but not all because in a few cases I'm not sure about how to do it.

[Roland Hedberg (roland-hedberg)]

On 8/4/10 18:26, Lorenzo Gil Sanchez wrote:
> src/saml2/binding.py:46: undefined name 'FORM_SPEC'
> src/saml2/binding.py:46: undefined name 'location'
> src/saml2/binding.py:46: undefined name 'base64'
> src/saml2/binding.py:46: undefined name 'authen_req'
> src/saml2/binding.py:47: undefined name 'os'
> src/saml2/binding.py:58: undefined name 'urllib'
> src/saml2/binding.py:59: undefined name 'deflate_and_base64_encode'
> src/saml2/binding.py:60: undefined name 'authen_req'
> src/saml2/binding.py:64: undefined name 'location'
> src/saml2/binding.py:158: undefined name 'binding'
>
> src/saml2/virtual_org.py:44: undefined name 'environ'
> src/saml2/virtual_org.py:51: local variable '_ignore' is assigned to but never used
>
src/saml2/binding.py and .../virtual_org.py are work in progress so I'm
not surprised you find faults.

> src/saml2/client.py:415: undefined name 'NameID'

Should be saml.NameID

> src/saml2/client.py:425: undefined name 'session_id'

Also in flux, should probably be sid()

> src/saml2/saml.py:148: local variable '_x' is assigned to but never used

That's why it's written as _x.
PyLint which I use uses this notation for variables that are placeholders.

I'm still on vacation :-) but will fix this before or during the weekend.

-- Roland

[Lorenzo Gil Sanchez (lgs)]

These issues were fixes in revision http://bazaar.launchpad.net/~roland-hedberg/pysaml2/main/revision/429