Launchpad itself

IDistroSeries.initialiseFromParent should be split out

Bug #612910 reported by Steve Kowalik
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Steve Kowalik
Launchpad itself 10.09 "Hungry Hippo"

Bug Description

The method initialiseFromParent and related methods should be split out into a separate class.

Related branches

lp:~stevenk/launchpad/move-ifp-from-idistroseries
Jelmer Vernooij (community): Approve (code)
Diff: 853 lines (+303/-351)
9 files modified
lib/lp/archiveuploader/tests/test_uploadprocessor.py (+6/-7)
lib/lp/registry/doc/distroseries.txt (+9/-11)
lib/lp/registry/interfaces/distroseries.py (+0/-29)
lib/lp/registry/model/distroseries.py (+2/-173)
lib/lp/soyuz/doc/initialise-from-parent.txt (+1/-4)
lib/lp/soyuz/doc/soyuz-set-of-uploads.txt (+7/-5)
lib/lp/soyuz/scripts/initialise_distroseries.py (+256/-0)
scripts/ftpmaster-tools/initialise-from-parent.py (+19/-104)
utilities/soyuz-sampledata-setup.py (+3/-18)
lp:~stevenk/launchpad/ifp-use-istore
Henning Eggers (community): Approve (code)
Diff: 84 lines (+12/-20)
2 files modified
lib/lp/soyuz/scripts/initialise_distroseries.py (+4/-10)
lib/lp/soyuz/scripts/tests/test_initialise_distroseries.py (+8/-10)
Steve Kowalik (stevenk)
Changed in soyuz:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Steve Kowalik (stevenk)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r11336 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11336>.

tags: added: qa-needstesting
Ursula Junque (ursinha)
Changed in soyuz:
status: In Progress → Fix Committed
milestone: none → 10.09
Steve Kowalik (stevenk)
tags: added: derivation
Revision history for this message
Steve Kowalik (stevenk) wrote :

I have QA'd this on dogfood by creating a new distroseries for Ubuntu, called nobby, and after doing some surgery on maverick (emptying queues, and disabling pending builds), I ran 'scripts/ftpmaster-tools/initialise-from-parent.py -a i386,amd64,powerpc,sparc nobby'.

The initialise-from-parent script no longer copies PARTNER packages either.

With one small database permission caveat that I have prepared a branch for, everything looks to have been copied fine.

Looking at the nobby distroseries page after initialisation showed me that the packaging links had been copied. After running 'cronscripts/update-pkgcache.py', the nobby distroseries page showed package counts and everything else expected.

I have verified that source packages, binary packages, packagesets and their related archivepermissions have been copied from maverick to nobby via SQL.

I have also had Julian check the new distroseries, and he agrees it has been initialised correctly.

tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r11473 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11473>.

tags: added: qa-needstesting
removed: qa-ok
Steve Kowalik (stevenk)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in soyuz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.