Show Widelands icon instead of default program icon in taskbar

[Hans Joachim Desserud]

When running a program, an icon and the program name is displayed in the taskbar at the bottom of the screen (on most operating systems). Presently, Widelands use a standard program icon which is very anonymous and says very little about what kind of program it is. I suggest this icon should be changed to the Widelands-icon which is used for the main executable as well as menu entries.

[Nasenbaer (nasenbaer)]

as side note: at least on linux this is not a problem of Widelands, but of the system wide installation - so the only way I can see to fix this for linux, is to add an build option "make install icon", that either installs the icons to the users icons directory or the system wide icons directory. Perhaps in that way we should as well install an desktop file (link to the program) to make widelands available to the Alt+F2 starter of the most common desktop environments.

BUT: actually I do not know any project that provides such an install feature, as normally packagers for the distributions care about that part.

On side of windows, this should work (at least it worked for quite a long time - but i remember that TinoM wrote about a problem with the icon more than a year ago... so perhaps it is still broken on windows?)

[Jens Beyer (qcumber-some)]

On Linux this is definitely the task of the packager, not of a "make install".

The only thing "make install" *could* do is provide a good icon at a prominent place where the packagers find it.

[Tino (tino79)]

I don't think this has to be done by the packaging process, it seems to be a problem with sdl.
Because the packaging (at least the cmake script for mingw) does build a resource out of the icon and includes it into the generated exe file.
The situation here on Win7 with a mingw build is the following:
- the binary widelands.exe shows the correct widelands icon (see wl_exe.png)
- also the correct icon is shown in the taskbar when runnning wl (wl_taskbar.png)
- the widelands windows itself shows only a generic application icon (wl_window.png)
- this icon is also shown in the list when pressing alt-tab (wl_tab.png)

So the packaging process seems to be fine (at least on windows with mingw) but the widelands application (sdl application) itself doesn't show the correct icon when running in window mode (again, at least on win).

[SirVer (sirver)]

So, one thing we should do is pack a call to SDL_WM_SetIcon in a prominent place in graphics startup code. This should help Tino. If this also fixes the problem of the Original poster is to be seen.

http://sdl.beuc.net/sdl.wiki/SDL_WM_SetIcon

[SirVer (sirver)]

Should be fixed in r 5621.

[SirVer (sirver)]

Released in build16-rc1