NUnit-agent should be reused on reload

[Charlie Poole]

This issue came up in discussing bug #582051, but is a separate issue.

When tests have been loaded in a separate process under nunit-agent.exe, and the
user reloads the tests after a change, the process is terminated and a new process
created. If the user had attached to the process for debugging, he will have to
do so all over again with the new process.

It would be more convenient for the user if NUnit simply instructed the existing
process to reload the tests.

[Charlie Poole (charlie.poole)]

This fix was committed and released with NUnit 2.5.8, but is now being reactivated.

While ProcessRunner was fixed to reuse the same agent process on reload, it turns out that higher level code creates an
entirely new ProcessRunner in order when reloading an assembly. This is done because changed parameters may call for
use of a different type of runner - for example, if the test was loaded in a separate process but is now to be reloaded in-process.

The implication here is that all runners need to know whether they are reloading a test or loading it initially, which is a change in the TestRunner interface.

[Charlie Poole (charlie.poole)]

Modified NUnit to stop any external process when the runner is disposed. Unloading/reloading tests will use
the same runner if possible, but will dispose of the old one and create a new one if the execution settings
have changed in a way that requires it.

[Peter Bessman (peter-peterbessman)]

This appears to be fixed as of 2.5.9.10308.

[Charlie Poole (charlie.poole)]

Thanks Peter,

It's marked as fixed in the accompanying release notes.

However, we don't mark it 'Fix Released' and close the bug until
it's actually released to production as opposed to a snapshot.

charlie

On Wed, Nov 10, 2010 at 11:11 AM, Peter Bessman
<email address hidden> wrote:
> This appears to be fixed as of 2.5.9.10308.
>
> --
> NUnit-agent should be reused on reload
> https://bugs.launchpad.net/bugs/612052
> You received this bug notification because you are a member of NUnit
> Developers, which is subscribed to NUnit V2.
>