zope.i18n

NAME_RE mismatch zope.i18n/__init__.py, zope.tal/taldefs.py

Bug #611746 reported by kleist
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zope.i18n
Fix Released
Medium
Christian Theune
zope.tal
Invalid
Undecided
Unassigned

Bug Description

This applies to the versions in Plone 4.0 coredev buildout rev. 38357 ...

* zope.i18n-3.7.3-py2.6.egg

* zope.tal-3.5.2-py2.6.egg

... as well as in trunk:

* http://zope3.pov.lt/trac/browser/zope.i18n/trunk/src/zope/i18n/__init__.py#L29

  NAME_RE = r"[a-zA-Z][-a-zA-Z0-9_]*"

* http://zope3.pov.lt/trac/browser/zope.tal/trunk/src/zope/tal/taldefs.py#L32

  NAME_RE = "[a-zA-Z_][-a-zA-Z0-9_]*"

  The mismatch is minimal, and should only affect names starting with an underscore. Maybe it's even intentional? But in that case, this should be documented.

Revision history for this message
Christian Theune (ctheune) wrote :

My fault. zope.tal isn't effected, it was just given as a reference.

Changed in zope.tal:
status: New → Invalid
Revision history for this message
Christian Theune (ctheune) wrote :

I find myself unable to track down why they parted. It looks like we're not using an import here to avoid unnecessary dependencies. OTOH this split already existed even before "the grand renaming".

I found no tests that would ensure that the underscore is there in zope.tal and so I just updated zope.i18n to follow along. *shrug*

Changed in zope.i18n:
assignee: nobody → Christian Theune (ct-gocept)
importance: Undecided → Medium
Revision history for this message
Christian Theune (ctheune) wrote :

Fixed in r117901

Changed in zope.i18n:
status: New → Fix Committed
Tres Seaver (tseaver)
Changed in zope.i18n:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.