svnlook diff doesn't work - fixed in trunk

[Klavs Klavsen]

Binary package hint: websvn

Using Ubuntu 10.04.

If you try to look at diffs using websvn - you get this error message: sh: cannot create : Directory nonexistent.

You can see it here (found their websvn - using google :) - http://svn.nethorus.org/websvn/blame.php?repname=nethorus&path=%2Fnethorus%2Fapp%2Fviews%2Fdevice_admin%2Fedit.html.erb&rev=170&peg=170

The fix is mentioned here: http://comments.gmane.org/gmane.comp.version-control.subversion.websvn.devel/1455

I fixed it and here's a patch (' changed to " - where > $tempname is):
--- /usr/share/websvn/include/svnlook.php.orig 2010-07-29 09:44:45.457443616 +0200
+++ /usr/share/websvn/include/svnlook.php 2010-07-29 09:36:24.377984087 +0200
@@ -601,7 +601,7 @@
                        $cmd = quoteCommand($config->getSvnCommand().' cat '.$this->repConfig->svnParams().quote($path.'@'.$rev).' | '.
                                $config->enscript.' --language=html '.
                                ($l ? '--color --pretty-print='.$l : '').' -o - | '.
- $config->sed.' -n '.$config->quote.'1,/^<PRE.$/!{/^<\\/PRE.$/,/^<PRE.$/!p;}'.$config->quote.' > $tempname');
+ $config->sed.' -n '.$config->quote.'1,/^<PRE.$/!{/^<\\/PRE.$/,/^<PRE.$/!p;}'.$config->quote." > $tempname");
                } else {
                        $highlighted = false;
                        $path = encodepath(str_replace(DIRECTORY_SEPARATOR, '/', $this->getSvnPath($path)));

[Jordan Hall (jordan-hall)]

This bug is still present and simply changing the line as in the patch shown in the original post does resolve this issue. I have just had to manually correct this myself, as it appears to still be present in the latest Ubuntu repository version available as of today.