collapse thread moves cursor when pointer not on a sub thread
Bug #611068 reported by
Arik
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| VM |
Fix Released
|
Low
|
Arik | ||
Bug Description
the collapse function was moving the pointer even when the current pointer position was on a message that did not become invisible as a result of collapsing the thread. The default action should be to move only if the pointed to message would become invisible and the no-move flag is not set.
| Changed in vm: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
| tags: | added: threads |
| Changed in vm: | |
| milestone: | none → 8.1.93a |
| Changed in vm: | |
| assignee: | nobody → Arik (akwm) |
| description: | updated |
Revision history for this message
| Arik (akwm) wrote | #1 |
| Changed in vm: | |
| status: | Confirmed → Fix Committed |
| Changed in vm: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hi Uday,
This bug is also fixed in the folding-fixes branch. I will use the --fixes option in commits from now, didn't realize launchpad had a feature like this. I think it's ready for the trunk.
Just to let you know, the save-excursion in collapse was taken out on purpose since (with the new handling of thread properties) the only time we change the cursor, we want to. It would weird to move the pointer and not the cursor since a subsequent command could have strange motion. This branch's changes allow to collapse and not move to the parent when the pointer is not with the cursor.
Thanks,
~Arik