Shares messages (from me) doesn't have the volume_id of the subtree/node_id
Bug #610702 reported by
Guillermo Gonzalez
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu One storage protocol |
Fix Released
|
High
|
Unassigned | ||
| ubuntuone-storage-protocol (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Bug Description
Shares and NotifyShare messages doesn't have a field for the volume_id of the shared subtree/node.
In order to map a share "from_me" to the node, we need the volume_id since we have multiple volumes (UDFVolumes and the RootVolume).
Related branches
lp:~verterok/ubuntuone-storage-protocol/volume_id-in-shares-from_me
- Rodrigo Moya (community): Approve
- John O'Brien (community): Approve
-
Diff: 235 lines (+165/-4)3 files modifiedtests/test_sharersp.py (+143/-0)
ubuntuone/storageprotocol/protocol.proto (+2/-0)
ubuntuone/storageprotocol/sharersp.py (+20/-4)
| Changed in ubuntuone-storage-protocol: | |
| status: | New → Confirmed |
| importance: | Undecided → High |
| assignee: | nobody → Ubuntu One Ops+ team (ubuntuone-ops+) |
| Changed in ubuntuone-storage-protocol (Ubuntu): | |
| status: | New → Confirmed |
| importance: | Undecided → High |
| tags: | added: chicharra chicharra-maverick |
Revision history for this message
| John O'Brien (jdobrien) wrote Re: [Bug 610702] [NEW] Shares messages (from me) doesn't have the volume_id of the subtree/node_id | #1 |
| Changed in ubuntuone-storage-protocol: | |
| status: | Confirmed → In Progress |
| Changed in ubuntuone-storage-protocol: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntuone-storage-protocol: | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntuone-storage-protocol (Ubuntu): | |
| assignee: | nobody → Ubuntu One Ops+ team (ubuntuone-ops+) |
| status: | Confirmed → Fix Released |
| status: | Fix Released → Confirmed |
| Changed in ubuntuone-storage-protocol (Ubuntu): | |
| status: | Confirmed → Fix Released |
| Changed in ubuntuone-storage-protocol: | |
| assignee: | Registry Administrators (registry) → nobody |
| Changed in ubuntuone-storage-protocol (Ubuntu): | |
| assignee: | Registry Administrators (registry) → nobody |
To post a comment you must log in.
Before changing share notifications, we should discuss these notifications, who gets them, and what the client does with
them.