test failures with xtradb in maria 5.2

[Mark Callaghan]

These fail when running: ./mtr --force --mysqld=--plugin-load=ha_xtradb.so --suite=innodb,innodb_plugin

innodb_plugin.innodb innodb.innodb-lock innodb_plugin.innodb-autoinc-44030 innodb_plugin.innodb-index innodb_plugin.innodb_bug21704 innodb_plugin.innodb_bug46000 innodb_plugin.innodb_bug51378 innodb_plugin.innodb_bug51920 innodb_plugin.innodb_bug52663 innodb_plugin.innodb_bug52745

The server was configured with:
./configure --enable-thread-safe-client --with-plugins=partition,csv,blackhole,myisam,heap,innodb_plugin --without-plugin-innobase --with-fast-mutexes --with-extra-charsets=all --with-debug C_EXTRA_FLAGS="-fno-omit-frame-pointer -fno-strict-aliasing -DHAVE_valgrind -Wall"

This uses gcc 4.2.1, centos 5.2, x86-64

I get a segfault on innodb_plugin.innodb_bug52745

100727 17:18:05 InnoDB: Assertion failure in thread 1221187904 in file page/page0zip.c line 3661
InnoDB: Failing assertion: blob_no < page_zip->n_blobs
InnoDB: We intentionally generate a memory trap.
InnoDB: Submit a detailed bug report to http://bugs.mysql.com.
InnoDB: If you get repeated assertion failures or crashes, even
InnoDB: immediately after the mysqld startup, there may be
InnoDB: corruption in the InnoDB tablespace. Please refer to
InnoDB: http://dev.mysql.com/doc/refman/5.1/en/forcing-recovery.html
InnoDB: about forcing recovery.
100727 17:18:05 [ERROR] mysqld got signal 6 ;
This could be because you hit a bug. It is also possible that this binary
or one of the libraries it was linked against is corrupt, improperly built,
or misconfigured. This error can also be caused by malfunctioning hardware.
We will try our best to scrape up some info that will hopefully help diagnose
the problem, but since we have already crashed, something is definitely wrong
and this may fail.

key_buffer_size=0
read_buffer_size=131072
max_used_connections=1
max_threads=153
threads_connected=1
It is possible that mysqld could use up to
key_buffer_size + (read_buffer_size + sort_buffer_size)*max_threads = 60676 K
bytes of memory
Hope that's ok; if not, decrease some variables in the equation.

thd: 0x2aaab41fe9c0
Attempting backtrace. You can use the following information to find out
where mysqld died. If you see no messages after this, something went
terribly wrong...
stack_bottom = 0x48c9d0f8 thread_stack 0x48000
/s/bld/52mariabzr/sql/mysqld(my_print_stacktrace+0x2e) [0x7e2dde]
/s/bld/52mariabzr/sql/mysqld(handle_segfault+0x353) [0x5b3393]
/lib64/libpthread.so.0 [0x328f80de70]
/lib64/libc.so.6(gsignal+0x35) [0x328ec30155]
/lib64/libc.so.6(abort+0x110) [0x328ec31bf0]
/s/bld/52mariabzr/mysql-test/var/plugins/ha_xtradb.so [0x2aaaaac7e44c]
/s/bld/52mariabzr/mysql-test/var/plugins/ha_xtradb.so [0x2aaaaabe7a92]
/s/bld/52mariabzr/mysql-test/var/plugins/ha_xtradb.so [0x2aaaaac9429d]
/s/bld/52mariabzr/mysql-test/var/plugins/ha_xtradb.so [0x2aaaaac9510d]
/s/bld/52mariabzr/mysql-test/var/plugins/ha_xtradb.so [0x2aaaaac95442]
/s/bld/52mariabzr/mysql-test/var/plugins/ha_xtradb.so [0x2aaaaac9dd39]
/s/bld/52mariabzr/mysql-test/var/plugins/ha_xtradb.so [0x2aaaaac415db]
/s/bld/52mariabzr/sql/mysqld(handler::ha_write_row(unsigned char*)+0x63) [0x6c6373]
/s/bld/52mariabzr/sql/mysqld(write_record(THD*, st_table*, st_copy_info*)+0x8a) [0x64a14a]
/s/bld/52mariabzr/sql/mysqld(mysql_insert(THD*, TABLE_LIST*, List<Item>&, List<List<Item> >&, List<Item>&, List<Item>&, enum_duplicates, bool)+0xa34) [0x64ee24]
/s/bld/52mariabzr/sql/mysqld(mysql_execute_command(THD*)+0x3175) [0x5c8525]
/s/bld/52mariabzr/sql/mysqld(mysql_parse(THD*, char const*, unsigned int, char const**)+0x19b) [0x5cc1bb]
/s/bld/52mariabzr/sql/mysqld(dispatch_command(enum_server_command, THD*, char*, unsigned int)+0x4e1) [0x5ccca1]
/s/bld/52mariabzr/sql/mysqld(do_command(THD*)+0x17d) [0x5cdddd]
/s/bld/52mariabzr/sql/mysqld(handle_one_connection+0xa3) [0x5be183]

[Kristian Nielsen (knielsen)]

According to http://bugs.mysql.com/bug.php?id=52745 , this is fixed in MySQL
5.1.49.

The fix is in the InnoDB code, so normally the fix would get into MariaDB in a
future merge of XtraDB based on a newer version of the InnoDB plugin.

However, with the recent reorganisation of the InnoDB code, it looks like
Oracle developers are now pushing fixes directly into a MySQL bzr source
tree. So I do not know if there will be a new separate release of the
innodb_plugin or if innodb_plugin->XtraDB->MariaDB merges will start to happen
in a different way. This needs to be checked.

One way or the other, the MySQL/innodb_plugin fix should eventually be merged
into MariaDB.

[Kristian Nielsen (knielsen)]

Fix has been merged into mariadb (long time ago...)