import of xspf without main title fails silently or crashes

Bug #609978 reported by Squeegee
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
Low
Mathias Brodala

Bug Description

Similar to a few other bugs for import (specifically for pls I found), if the root trackList object doesn't contain a <title> element (which, btw, rythmbox does not export when creating), then exaile crashes or fails silently. In the case of failing silently, it will eventually crash, but it happens later (normally pretty soon, but later than the moment its imported).

This was for Exaile 3.2 on Fedora 13 x86-64.

To recreate, export an xlps from Rhythmbox, then attempt to import it into Exaile. For me, it fails consistantly.

Related branches

Revision history for this message
Squeegee (russg) wrote :

Oops - it's version 0.3.2, not 3.2.

Revision history for this message
Squeegee (russg) wrote :

One way to fix this would be to default the name to the filename if the track element is missing. Currently, the code just assumes the title element exists.

Ok, I suppose I should just submit a patch for this - 2 or 3 lines at most.

Revision history for this message
Mathias Brodala (mathbr) wrote :

Fixed with r3666 in trunk and r3440 in 0.3.2.x, thanks for finding.

Changed in exaile:
assignee: nobody → Mathias Brodala (mathbr)
importance: Undecided → Low
milestone: none → 0.3.2.1
status: New → Fix Committed
reacocard (reacocard)
Changed in exaile:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.