archive.checkUpload() OOPSes when distoseries is set to a stable release

[Michael Bienia]

The LP API function fails with an OOPS if distroseries is passed a stable release (e.g. lucid).

{{{
$ lp-shell
Connected to LP service "edge" with API version "1.0":
Note: LP can be accessed through the "lp" object.
>>> ubuntu = lp.distributions['ubuntu']
>>> archive = ubuntu.main_archive
>>> lucid = ubuntu.getSeries(name_or_version='lucid')
>>> archive.checkUpload(component='universe', distroseries=lucid, person=lp.me, pocket='Release', sourcepackagename='ubuntu-dev-tools')
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/usr/lib/python2.6/dist-packages/lazr/restfulclient/resource.py", line 528, in __call__
    url, in_representation, http_method, extra_headers=extra_headers)
  File "/usr/lib/python2.6/dist-packages/lazr/restfulclient/_browser.py", line 277, in _request
    raise HTTPError(response, content)
HTTPError: HTTP Error 500: Internal Server Error
Response headers:
---
connection: close
content-length: 20
content-type: text/plain
date: Thu, 22 Jul 2010 19:16:59 GMT
server: zope.server.http (HTTP)
status: 500
vary: Accept-Encoding
via: 1.1 wildcard.edge.launchpad.net
x-lazr-oopsid: OOPS-1664ED2148
x-powered-by: Zope (www.zope.org), Python (www.python.org)
---
Response body:
---
CannotUploadToPocket
---
}}}

The error message itself is correct but I don't assume it should cause an OOPS to transfer it.

[Julian Edwards (julian-edwards)]

Thanks for reporting this.

For the fixer:

In interfaces/archive.py, the CannotUploadToPocket class is missing a:
webservice_error(403)

[Launchpad QA Bot (lpqabot)]

Fixed in stable r11238 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11238>.