Auto-connected scopes lost if they fail to connect

[Peter Mousley]

This was first reported in https://bugs.launchpad.net/stellarium/+bug/596167/comments/8

In the Telescope Control plugin, if a scope is set to auto connect at start up and the connection fails (serial port not available for example), the scope is removed from the list of available scopes. The scope and it's settings then need to be re-created.

[Bogdan Marinov (daggerstab)]

I think that creating a branch for a small code change like this one is overkill. :)

I'll have a look at it later today, though I'm sure that I've seen it already as a patch in the mailing list.

[Peter Mousley (scrupeus)]

On 22/07/2010 15:51, Bogdan Marinov wrote:
> I think that creating a branch for a small code change like this one is
> overkill. :)
>
No kidding! But it's not branching that's the problem, that's quick and
easy. It's creating the merge proposal that's a real pain and time
consumer. But the problem is patches are being submitted and getting
'lost'. At least this way they remain on the radar and are very obvious
that they're awaiting merging. See my thread with Fabien about 'Getting
patches into trunk', which should be extended to 'Getting patches merged
anywhere' - happy to hear your comments about it.

(This raises an important issue... Did you even see the merge proposal
for this patch or only the bug report? If plugin maintainers are not
going to see merge proposals, then either Fabien needs to forward them
to you or commit them himself. Probably best you get added to the merge
proposal notifications if you're not already.)

> I'll have a look at it later today, though I'm sure that I've seen it
> already as a patch in the mailing list.
>
Yep, but as previously posted patches were being submitted and not
receiving feedback for weeks (this one was originally posted 5 weeks
ago, but joined to a related bug). I'm going through everything I've
posted and ensuring each patch is at least a bug report on LP and, for
most of them, a merge proposal.

Thanks for looking,
Pete

[Bogdan Marinov (daggerstab)]

I think I found out what exactly is the problem: a disconnected, auto-started telescope will disappear only if it is the only one telescope. The function that tries to load it at start-up keeps a count of the successfully loaded telescopes, and if it is 0, it simply doesn't add the information read from the telescopes configuration file.

The changes in your branch are not an acceptable solution, as they remove a way of reporting initialization errors.

[Bogdan Marinov (daggerstab)]

A fix has been committed as revision 4805 in Stellarium's trunk branch in the Bazaar repository at Launchpad:
http://bazaar.launchpad.net/~stellarium/stellarium/trunk/revision/4805