Implement filterbuttons on Feeds

Bug #608336 reported by Paul Everitt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KARL3
Fix Released
Medium
Carlos de la Guardia

Bug Description

Chrissy has a UI in place and Tres has a backend somewhat in place. Time to merge the two.

On Feeds, the user clicks on a filterbutton ("All", "My Communities", "My Content") and sees differently-filtered results. How this should work:

1) The page loads and "knows" (sticky) what is the correct button to set.

2) A URL is constructed that fetches those results via JSON, renders HTML, then starts polling for updates.

3) If the user clicks a different filterbutton, a different URL is constructed, telling the server to return a different pile of data.

Spec
=======

1) Sticky. *If possible*, going to the Feeds tab should "remember" whichever was your last chosen filter, display it as the selection, and use it for the data.

** Throw this out if it takes more than one hour. **

2) Choosing a different pile of data should clear the "last updated" and return the full batch.

3) Make sure the URL constructed from one polling to the next retains the selection.

4) Implement the server side that looks in the request.params for the selection. I believe Tres has already done most of this, just make sure you follow his lead.

5) Make sure clicking the button follows the throbber protocol. Clicking a button starts a request, so the throbber state should be changed to "polling". If you use assign the new URL then call .get_items in the JS, it should handle it all itself.

Changed in karl3:
assignee: nobody → Carlos de la Guardia (cguardia)
importance: Undecided → Medium
milestone: none → m44
status: New → Confirmed
Changed in karl3:
status: Confirmed → In Progress
Revision history for this message
Carlos de la Guardia (cguardia) wrote :

Ran out of hours for the week. Everything works now, but I need to fix tests to mark this finished.

Changed in karl3:
milestone: m44 → m45
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Carlos, this is probably your highest priority. What day can you work this week?

Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Oops, sorry on that last comment. For this ticket, I meant to ask: did you wrap this up? I think you checked in some tests.

Revision history for this message
Carlos de la Guardia (cguardia) wrote :

Yes, I checked in a good number of tests, which cover the backend part of the feature. Apparently, there are currently no tests for the views, so I guess it would be a good idea to add some. One hour should be enough for that. I can do it on Monday.

Revision history for this message
Paul Everitt (paul-agendaless) wrote :

I think Tres has filled in the details on tests, so I'll close this one.

Changed in karl3:
status: In Progress → Fix Committed
Changed in karl3:
milestone: m45 → m46
Revision history for this message
JimPGlenn (jpglenn09) wrote :

fixed

Changed in karl3:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.