Issues in commit 146 (twisted)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Low
|
justinsb |
Bug Description
Had put these as comments in the merge request, but as it's already been merged, opening a bug...
There's a missing call to request.finish() in render_GET in ImageResource
+ request.finish()
return server.NOT_DONE_YET
---
There's what looks like a typo bug in line 537:
images = [i for i in image.Image.all() if i.is_authorized
Should probably be...
images = [i for i in image.Image.all() if i.is_authorized
---
Some issues inherited from the old code, but this is probably the time to clean it up:
1) If the Authorization header is not set, this throws a 500 error, where it should raise exception.
Presumably the except clause needs to be broader than "except exception.Error, ex:"
2) Should we be using the 'modern' exception syntax "exception exception.Error as ex"?
http://
3) There's a pretty big FIXME in there "# FIXME: check signature here!" - should we should open a separate bug for that?
Related branches
- Vish Ishaya (community): Approve
-
Diff: 43 lines (+8/-4)1 file modifiednova/objectstore/handler.py (+8/-4)
Changed in nova: | |
importance: | Undecided → Low |
status: | New → Fix Committed |
assignee: | nobody → justinsb (justin-fathomdb) |
Changed in nova: | |
status: | Fix Committed → Fix Released |
Proposed merge for lp:~justin-fathomdb/nova/bug607501, split the FIXME bug out into 607512.