os.kill exists on win32 Python 2.7 but isn't real posix signalling support

Bug #607406 reported by Martin Packman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Medium
Martin Packman

Bug Description

Python 2.7 added an emulated os.kill on Windows that goes through GenerateConsoleCtrlEvent in the limited circumstances that that sort-of works with. Tests expecting to be able to use the existence of os.kill to infer that they can send arbitrary signals to another process are likely to be disappointed by that level of support.

Furthermore, some of the tests that use skip_if_plan_to_signal=True are written in a generally nixy style so fail for other unrelated reasons, like mismatched line endings.

Affected tests include at least:
    bb.test_serve.TestBzrServe.test_bzr_serve_port_readonly
    bb.test_serve.TestBzrServe.test_bzr_serve_port_readwrite
    bb.test_serve.TestBzrServe.test_bzr_serve_supports_protocol
    bt.test_selftest.TestActuallyStartBzrSubprocess.test_start_and_stop_bzr_subprocess_send_signal

Tags: python27

Related branches

Revision history for this message
Martin Pool (mbp) wrote :

Please feel free to triage as you file. (You should have permission?)

Changed in bzr:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Vincent Ladeuil (vila) wrote :

and to add to poolie's remark: feel free to define the right bzrlib.test.features feature so the tests can require it :)

In the mean time, making the test fail if it tries to send an unsupported signal will ensure we detect such tests.

Martin Packman (gz)
Changed in bzr:
assignee: nobody → Martin [gz] (gz)
milestone: none → 2.3b1
status: Confirmed → Fix Released
Martin Packman (gz)
tags: added: python27
removed: python2.7
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.