IO thrashing checking for file existence

Bug #607206 reported by Mikkel Kamstrup Erlandsen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Unity
Invalid
Undecided
Unassigned
unity-lens-files
Invalid
Undecided
Unassigned
unity (Ubuntu)
Invalid
Undecided
Unassigned
unity-place-files (Ubuntu)
Invalid
Undecided
Unassigned

Bug Description

When adding files to the model we stat() the URI each and every time. We need something which is more IO-friendly. Mikkel and Neil has concocted some evil plans for this...

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

For reference see bug #489194 in Zeitgeist: "Implement storage monitor (devices and connectivity)".

This is The Right Fix (TM) but will probably not be ready for Maverick

Seif Lotfy (seif)
Changed in unity-place-files:
status: New → Fix Released
status: Fix Released → New
Revision history for this message
Alex Launi (alexlauni) wrote :

Is this still an issue? I just grepped the source and don't see any calls to stat, and afaik File.new_for_uri doesn't actually stat the file.

Changed in unity:
status: New → Incomplete
Changed in unity-place-files:
status: New → Incomplete
Changed in unity-place-files (Ubuntu):
status: New → Incomplete
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

@Alex: setting all as invalid. It's still

Changed in unity (Ubuntu):
status: New → Incomplete
Changed in unity:
status: Incomplete → Invalid
Changed in unity-place-files:
status: Incomplete → Invalid
Changed in unity (Ubuntu):
status: Incomplete → Invalid
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

it's still an issue, but the new the zg release fixes it (not unity related)

Changed in unity-place-files (Ubuntu):
status: Incomplete → Invalid
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Yes, it's still and issue, but what @didrocks says is not entirely true. The latest Zeitgeist releases 0.7.0 doesn't fox this. There is a chance that 0.8 might fix it, but the code has not landed in ZG trunk yet, so there is no guarantee.

@Alex: The stat() is hiding under file.query_exists()

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.