Deprecate swf embedded objects

Bug #604839 reported by François Marier
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon

Bug Description

The SWFObject detection script we used in the internal media blocktype is using this upstream code:

  http://blog.deconcept.com/swfobject/

but it has now been replaced by this one, which is up to version 2.2:

  http://code.google.com/p/swfobject/

Changed in mahara:
milestone: none → 1.3.0
importance: Undecided → Medium
Changed in mahara:
status: New → Confirmed
Changed in mahara:
milestone: 1.3.0 → none
Changed in mahara:
importance: Medium → Low
milestone: none → 1.4.0
Changed in mahara:
milestone: 1.4.0 → none
tags: added: upstream
Revision history for this message
Robert Lyon (robertl-9) wrote :

This still looks like it needs to be done

Changed in mahara:
milestone: none → 1.9.0
Revision history for this message
Aaron Wells (u-aaronw) wrote :

The upgrade is non-trivial. SWFObject 2.2 is not backwards-compatible with SWFObject 1.5. The trickiest part is that the <script> tags are meant to go in the document head. On the other hand, Mahara has several ways of adding things to the document head, so it's not insurmountable.

http://code.google.com/p/swfobject/wiki/documentation

tags: added: snack-sized
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 1.9.0 → 1.10.0
importance: Low → Medium
assignee: nobody → Robert Lyon (robertl-9)
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 1.10.0 → 1.11.0
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 15.04.0 → 15.04.1
no longer affects: mahara/15.10
Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → Won't Fix
Revision history for this message
Aaron Wells (u-aaronw) wrote :

To clarify what this library is for, it's what we use to display SWF files uploaded by users. So, unless we want to drop support for displaying SWF files in the embedded media block, we shouldn't consider this bug to be a "Won't Fix".

That said, the time may soon be right to drop support for .SWF files.

Changed in mahara:
status: Won't Fix → Confirmed
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.04.0 → 16.10.0
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.10.0 → 16.10.1
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.10.1 → 17.04.0
Changed in mahara:
assignee: Robert Lyon (robertl-9) → Cecilia Vela Gurovic (ceciliavg)
Robert Lyon (robertl-9)
Changed in mahara:
assignee: Cecilia Vela Gurovic (ceciliavg) → Robert Lyon (robertl-9)
Robert Lyon (robertl-9)
summary: - Upgrade swfobject to version 2.2 (new upstream)
+ Deprecate swf embedded objects
Changed in mahara:
milestone: 17.04.0 → 17.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7572

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7572
Committed: https://git.mahara.org/mahara/mahara/commit/0b30a77a001eb49ec8338ee368811ef88577d1a2
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0b30a77a001eb49ec8338ee368811ef88577d1a2
Author: Robert Lyon <email address hidden>
Date: Wed Mar 29 11:36:10 2017 +1300

Bug 604839: Removing support for embedding .swf objects

behatnotneeded - to come later

Change-Id: I42f40d997559c4fda132e9c36dc8e2c9d016c61e
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
tags: added: usermanualupdate
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.