Account Payment Report

Bug #604615 reported by Vincent Renaville@camptocamp
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
Ravindra Mekhiya(OpenERP)

Bug Description

Hello,

Many of our customers complain about the layout of the Account Payment Report, so we have made a patch for it ;)
We have adapt the layout, add Total, enlarge the bank account column,add amount in company currency ,etc ...
I think it's suitable for all OpenERP customers, so can you review it and integrate it in the next stable version ?

You will find a patch attached to this bug

thanks for your precious help,

Vincent

Related branches

Revision history for this message
Vincent Renaville@camptocamp (vrenaville-c2c) wrote :
Changed in openobject-addons:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Ravindra Mekhiya(OpenERP) (rme-openerp) wrote :

Hello Vincent,

I have applied your patch.
The layout seems quite impressive.
All the required fields have been listed.

However, the header line isn't continuous.
I have attached the screen-shot after applying your patch.

Would you please see through it and send a new patch?

Thanks.

Revision history for this message
Vincent Renaville@camptocamp (vrenaville-c2c) wrote :

Hi,

Thanks for your comment, I have just applied my patch on the last stable.
I have no problem with layout (see pdf attached),
and I have also noticed that amount and amount currency are inverted (you can also view it in pdf attached).
Can you test it again, it's really change.

Thanks for your precious help,

Vincent

Revision history for this message
Vincent Renaville@camptocamp (vrenaville-c2c) wrote :

Hi,

Do you need some more information ?
We are closed to a solution, one more review an we will have a greate payment report ;) .

Vincent

Revision history for this message
Ravindra Mekhiya(OpenERP) (rme-openerp) wrote :

Hi Vincent,

The patch can be approved,thanks.

Is it possible to send us an SXW file ?

Thanks.

Revision history for this message
Vincent Renaville@camptocamp (vrenaville-c2c) wrote :

Hi,

Thanks for your reply, I have no SXW file.
I have corrected the RML file directly.

Sorry for that,

Vincent

Revision history for this message
Vincent Renaville@camptocamp (vrenaville-c2c) wrote :

Hi,

Could you please applied my patch ;) , it's really important to have the SXW ?

Thanks for your help,

Vincent

Revision history for this message
Ravindra Mekhiya(OpenERP) (rme-openerp) wrote :

Hello Vincent,

Yes, the file is important because user may want to change the SXW file via OpenOffice Report Designer tool.
There is no other reason we ask you to attach the file.

I hope you understand the importance.

Thanks for the care.

Revision history for this message
Vincent Renaville@camptocamp (vrenaville-c2c) wrote :

Hello,

I have take time to give you a order.sxw file, you will find it attached

After review, you can commit the patch :)

Thanks for your precious help

Vincent

Changed in openobject-addons:
assignee: nobody → RME(OpenERP) (rme-openerp)
Revision history for this message
Ravindra Mekhiya(OpenERP) (rme-openerp) wrote :

Hello Vincent,

After conversion of your .SXW file into .RML file, it really doesn't match the RML sent by you earlier.

Plus, the output also differs.

Here I have attached both reports...
  1) First .RML file's report
  2) .SXW file converted into .RML file's report

Thanks for your efforts,
we appreciate.

Revision history for this message
Ravindra Mekhiya(OpenERP) (rme-openerp) wrote :

.SXW file's .RML file Account Payment Report.

Revision history for this message
Vincent Renaville@camptocamp (vrenaville-c2c) wrote :

Hello,

I'm too impatient to close this bug :

You will find in attachment the an new version of the patch and the new SXW version

Thanks for you help,

Vincent Renaville

Revision history for this message
Vincent Renaville@camptocamp (vrenaville-c2c) wrote :
Revision history for this message
Stephane Wirtel (OpenERP) (stephane-openerp) wrote :

Vincent,

There is a patch for the 6.0 about this report ?

Thanks

Revision history for this message
Stephane Wirtel (OpenERP) (stephane-openerp) wrote :

In fact, I have to discuss with the team, because in 5.0, you know we only accept the bugfixes and not the improvements.

In this case, it's between the improvement and the bugfix, because the current layout seems to be wrong.

Stéphane

Revision history for this message
Vincent Renaville@camptocamp (vrenaville-c2c) wrote :

Hi Stephane,

I don't have a patch for the 6.0, I can't currently spend more time on this bug.
but I think It will not be a big deal for your team to make the patch ;) .

You are right, it's between a bugfix and an improvement.
But if you can't use a report because you don't have the right information, for me it's a bug even if the report doesn't crash at runtime ;)

Vincent

Revision history for this message
Stephane Wirtel (OpenERP) (stephane-openerp) wrote :

I agree with you !

Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

It has been corrected by revision 2816 <email address hidden> authored to Vincent.
Thanks for all your efforts and time.

Changed in openobject-addons:
milestone: none → 5.0.13
status: In Progress → Fix Released
Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

We will fix/improve it on trunk too.
Thanks.

Revision history for this message
Ravindra Mekhiya(OpenERP) (rme-openerp) wrote :

Hello,

It has been fixed into trunk.

Thanks.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.