filtering on non-existant tags returns all tasks

[Bryce Harrington]

Steps to reproduce:

0. Startup gtg
1. ./gtcli postpone @NonexistantTag 2011-07-05

This should be a no-op. The tag doesn't exist, so when gtcli calls timi.get_tasks_filtered(filters) via DBUS, no tasks should be returned. Instead, it ignores the filter and returns all tasks as if that tag had not been specified as a filter.

[Bryce Harrington (bryce)]

I've attached a branch with a change to the filter code that seems to fix it (at least for the test case in the description).

It seems that in __is_displayed(), if there is a tag filter using a tag that is not defined, it skips processing of it (which is correct) but the logic falls through to returning a True result by default. This branch changes this particular error case to default as False.

[Lionel Dricot (ploum-deactivatedaccount)]

Thanks Bryce,

We will try to merge you branch ASAP

[Izidor Matušov (izidor)]

Thank you Bryce for the fix. LibLarch evolved over the time, I added a small fix for DBUS interface to use own LibLarch view => I had to merge it manually. I am not sure if Launchpad understands that :-)

The fix is in rev. 959.