Request::get_base_required_time: WARNING nr = 1 but count is 1, which is not allowed according to the comment for this function

[Marty Shannon]

I'm pretty sure I've been seeing this since at least Release 15, but for certain it's in bzr5412. It happens a *lot*.

[Scott Howard (showard314)]

Quick skim of the code: in request.cc, should the warning be thrown if (m_count < nr) not when (m_count <= nr)? I believe that the number requested can equal to the maximum size. See the original code below:

/**
 * Return the point in time at which we want the item of the given number to
 * be delivered. nr is in the range [0..m_count[
*/
int32_t Request::get_base_required_time
 (Editor_Game_Base & egbase, uint32_t const nr) const
{
 if (m_count <= nr)
  log
   ("Request::get_base_required_time: WARNING nr = %u but count is %u, "
    "which is not allowed according to the comment for this function\n",
    nr, m_count);
 int32_t const curtime = egbase.get_gametime();

[SirVer (sirver)]

not critical. -> build 17

[Hans Joachim Desserud (hjd)]

I'm happy someone has finally looked at this, since this warning pops up all the time. Though, for the future it would probably be better to push fixes to different bugs to different branches, to make it easier to review and merge them one at a time.

[SirVer (sirver)]

Released in build17-rc1.