Problem with some users' websites field and edit profile form

[Chris Rossi]

Some users, for some reason, have a value for their 'websites' field of ('',). In OSI there are 369 profiles:

$ bin/debug
>>> len([p for p in root['profiles'].values() if p.websites == ('',)])
369

In this case, both edit_profile_view and admin_edit_profile_view exhibit the same behavior:

The textarea for websites displays two quotation marks: ""

Submitting the form causes the from to come back as though there is a validation error but no validation error is displayed.

After clearing the websites field the form can be submitted successfully.

[Paul Everitt (paul-agendaless)]

Handing some things over to Tres.

[Tres Seaver (tseaver)]

Fix committed on the karl trunk in r5649.

[Paul Everitt (paul-agendaless)]

Got done in M43.

[JimPGlenn (jpglenn09)]

Can't confirm this is fixed.
Tested with profiles that had "" before the fix, and they still have "".
Submitting form with "" still does not produce an error message.

I created a new user on OSI and did not get the "" error though.

[Paul Everitt (paul-agendaless)]

Hi Tres, in comment #4 that he still thinks there's a problem. (He's nosy on this and all issues, so feel free the ask for more information.)

[Tres Seaver (tseaver)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased

The software fix didn't do anything to work around the profiles already
borked by the bug. Here is what I did to clean them up:

 $ ssh karl.soros.org
 $ sudo /opt/karl3/bin/debug
 >>> for profile in root['profiles'].values():
 ... if None in profile.websites:
 ... print profile.email
 ...
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 <email address hidden>
 >>> for profile in root['profiles'].values():
 ... if None in profile.websites:
 ... profile.websites = filter(None, profile.websites)
 ...

 >>> for profile in root['profiles'].values():
 ... if None in profile.websites:
 ... print profile.email
 ...
 >>> import transaction; transaction.commit()

Tres.
- --
===================================================================
Tres Seaver [phone] <email address hidden>
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev....

[Chris Rossi (chris-archimedeanco)]

Hmm, when I looked at this, the problem I saw was there was an empty string
in the websites field, not a None. I see now that they are both issues:

>>> len([p for p in root['profiles'].values() if '' in p.websites])
363
>>> len([p for p in root['profiles'].values() if None in p.websites])
101

There is also the issue of the missing validation error message in the edit
form.

Chris

On Fri, Jul 9, 2010 at 12:24 PM, Tres Seaver <email address hidden> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> status fixreleased
>
> The software fix didn't do anything to work around the profiles already
> borked by the bug. Here is what I did to clean them up:
>
> $ ssh karl.soros.org
> $ sudo /opt/karl3/bin/debug
> >>> for profile in root['profiles'].values():
> ... if None in profile.websites:
> ... print profile.email
> ...
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> <email address hidden>
> vkazanska@osi...