XtraDB compile error with VS 10 64-bit

Bug #600744 reported by Hakan Küçükyılmaz
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MariaDB
Fix Released
High
Unassigned
Percona-XtraDB
Won't Fix
High
Hakan Küçükyılmaz

Bug Description

Compiling XtraDB with VS 2010 on 64-bit Windows fails with several errors all of the type:

Error 10 error C2440: 'initializing' : cannot convert from 'ulint *' to 'unsigned long *' C:\Users\hakan\work\monty_program\maria-5.2\storage\xtradb\handler\ha_innodb.cc 10410

The code in question is:

Error 10 error C2440: 'initializing' : cannot convert from 'ulint *' to 'unsigned long *' C:\Users\hakan\work\monty_program\maria-5.2\storage\xtradb\handler\ha_innodb.cc 10410

static MYSQL_SYSVAR_ULONG(use_purge_thread, srv_use_purge_thread,
  PLUGIN_VAR_RQCMDARG | PLUGIN_VAR_READONLY,
  "Number of purge devoted threads. #### over 1 is EXPERIMENTAL ####",
  NULL, NULL, 1, 0, 64, 0);

And line 10410 is
  NULL, NULL, 1, 0, 64, 0);

Tags: windows
Changed in maria:
assignee: nobody → Hakan Küçükyılmaz (hakan-askmonty)
status: New → Confirmed
importance: Undecided → High
Revision history for this message
Bo Thorsen (bo.thorsen) wrote :

The problem is that xtradb tries to store a ulint using unsigned long. This works on all architecures except 64 bit Windows because ulint is defined as __int64 on that. There is currently no MYSQL_SYSVAR_xx that matches this, so I have added a MYSQL_SYSVAR_ULINT and changed the calls to this. See the attached patch.

Revision history for this message
Bo Thorsen (bo.thorsen) wrote :

New attempt at a patch. This one doesn't modify plugin.h but is local to xtradb.

affects: maria → percona-xtradb
Changed in maria:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
Bo Thorsen (bo.thorsen) wrote :

Here is a smaller patch, which is the one I'll push to MariaDB.

Changed in maria:
status: Confirmed → Fix Committed
Changed in maria:
milestone: none → 5.2
Bo Thorsen (bo.thorsen)
tags: added: windows
Changed in maria:
status: Fix Committed → Fix Released
Revision history for this message
Stewart Smith (stewart) wrote :

All development of XtraDB has moved under the Percona Server project - https://launchpad.net/percona-server - If this bug can be reproduced against current Percona Server, please file this bug against percona-server (you can simply do so by using the "Also affects project" link above).

Thanks,
Stewart Smith
Director of Server Development
Percona.

Changed in percona-xtradb:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.