Template selector on template approval form
Bug #600673 reported by
Jeroen T. Vermeulen
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Jeroen T. Vermeulen | ||
Bug Description
Approving a template upload involves filling out both name and domain. If the template is an update to an existing one (e.g. because of a path change or missing path component), that can go wrong sometimes. For instance, if the template name is foo-bar then it's not obvious whether the domain is foo-bar or foo_bar (and in principle it could as easily be foobar or zitpick3).
It'd be helpful to show the dropdown with existing templates not just for translation files, but for templates as well. The queue reviewer could then pick an existing template there, and it would pre-fill the name and domain fields.
Related branches
lp:~jtv/launchpad/bug-600673
- Māris Fogels (community): Approve (python, js)
- Launchpad code reviewers: Pending (js) requested
-
Diff: 667 lines (+348/-55)8 files modifiedlib/lp/testing/factory.py (+31/-14)
lib/lp/translations/browser/tests/test_translationimportqueueentry.py (+22/-4)
lib/lp/translations/browser/translationimportqueue.py (+34/-1)
lib/lp/translations/javascript/importqueue.js (+0/-7)
lib/lp/translations/javascript/importqueueentry.js (+108/-10)
lib/lp/translations/templates/translation-import-queue-macros.pt (+0/-1)
lib/lp/translations/templates/translationimportqueueentry-index.pt (+5/-0)
lib/lp/translations/windmill/tests/test_import_queue.py (+148/-18)
| Changed in rosetta: | |
| importance: | Undecided → Low |
| status: | New → Triaged |
| tags: | added: import-queue |
Revision history for this message
| Jeroen T. Vermeulen (jtv) wrote | #1 |
| Changed in rosetta: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Jeroen T. Vermeulen (jtv) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #2 |
| Changed in rosetta: | |
| milestone: | none → 10.08 |
| tags: | added: qa-needstesting |
| Changed in rosetta: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Данило Шеган (danilo) wrote | #3 |
| tags: | removed: qa-needstesting |
| tags: | added: qa-ok |
| Changed in rosetta: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Demo now available at http://