configure test for libpng fails with >=libpng-1.4

Bug #600328 reported by pavelo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Armagetron Advanced
Fix Committed
Medium
Unassigned

Bug Description

checking whether libpng is installed... yes
checking for png_check_sig... no
configure: error: You need libpng to compile Armagetron.

the problem is that configure checks for the existance of the png_check_sig() function. however, in new libpng this is defined as a macro so the test blows up. I simply replaced the tested function with png_sig_cmp() and it works like a charm :)

(i haven't checked, but i assume png_sig_cmp() also exists on older versions of libpng)

Index: configure.ac
===================================================================
--- configure.ac (revision 9424)
+++ configure.ac (working copy)
@@ -981,7 +980,7 @@
 CPPFLAGS="$CPPFLAGS `libpng-config --cflags`"
 LIBS="$LIBS $PNGLIBS"

-AC_CHECK_FUNC(png_check_sig,
+AC_CHECK_FUNC(png_sig_cmp,
 ,
 AC_MSG_ERROR([You need libpng to compile Armagetron.]))

Revision history for this message
Luke-Jr (luke-jr) wrote :

I think this is already fixed somewhere...

Revision history for this message
pavelo (pavelo) wrote :

i checked the main bzr branch and svn... they both exhibit the problem....

Revision history for this message
dlh (dlh) wrote :

Was fixed in bzr revno 1198 for 0.2.8 on 2010-03-19, and the fixed was merged into trunk cleanly.

Changed in armagetronad:
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.