regression tests do not use optimisation

[Garth Wells]

The regression test do not test with optimisations. They should test both with and without optimisation (-O flag). Bugs have been introduced unnoticed because of this,

[Kristian B. Ølgaard (k.b.oelgaard)]

I think we have discussed this before, but are you planning on using the same references for the output for all combinations of optimisations? The *.h files will obviously be different, but the resulting tensors should be equal for all demos of course.

[Marie Rognes (meg-simula)]

Yes, that is the setup in the new branch. Just waiting for the tests to pass before merging.

--
Marie

On 18. nov. 2011, at 22:28, Kristian B. Ølgaard <email address hidden> wrote:

> I think we have discussed this before, but are you planning on using the
> same references for the output for all combinations of optimisations?
> The *.h files will obviously be different, but the resulting tensors
> should be equal for all demos of course.
>
> --
> You received this bug notification because you are a member of FFC Core
> Team, which is subscribed to FFC.
> https://bugs.launchpad.net/bugs/600131
>
> Title:
> regression tests do not use optimisation
>
> Status in FEniCS Form Compiler:
> In Progress
>
> Bug description:
> The regression test do not test with optimisations. They should test
> both with and without optimisation (-O flag). Bugs have been
> introduced unnoticed because of this,
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ffc/+bug/600131/+subscriptions

[Kristian B. Ølgaard (k.b.oelgaard)]

Nice work on the new tests by the way, I assume it is trivial to add
tests for the other combinations of quadrature optimisations?
Not that I think we should do this just now :) or perhaps if we just
compare the output and not the header files for those particular
optimisations.

Kristian

On 28 November 2011 10:37, Marie Rognes <email address hidden> wrote:
> ** Changed in: ffc
>       Status: In Progress => Fix Committed
>
> --
> You received this bug notification because you are a member of FFC Core
> Team, which is subscribed to FFC.
> https://bugs.launchpad.net/bugs/600131
>
> Title:
>  regression tests do not use optimisation
>
> Status in FEniCS Form Compiler:
>  Fix Committed
>
> Bug description:
>  The regression test do not test with optimisations. They should test
>  both with and without optimisation (-O flag). Bugs have been
>  introduced unnoticed because of this,
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ffc/+bug/600131/+subscriptions
>

[Marie Rognes (meg-simula)]

Should be easy to add yes, by adding arguments to this list:
(cf. L350-- 354 in test/regression/test.py)

     # Adjust which test cases (combinations of compile arguments) to
     # run here
     test_cases = ["-r auto"]
     if (not bench and not fast):
         test_cases += ["-r quadrature", "-r quadrature -O"]

+ updating test/regression/references/update.sh

Some more, but fairly trivial, tuning would be needed if you only want to
perform some parts of the generate-validate-compile-run-validate
test tool chain.

--
Marie

On 11/28/2011 10:54 AM, Kristian B. Ølgaard wrote:
> Nice work on the new tests by the way, I assume it is trivial to add
> tests for the other combinations of quadrature optimisations?
> Not that I think we should do this just now :) or perhaps if we just
> compare the output and not the header files for those particular
> optimisations.
>
> Kristian
>
> On 28 November 2011 10:37, Marie Rognes<email address hidden> wrote:
>> ** Changed in: ffc
>> Status: In Progress => Fix Committed
>>
>> --
>> You received this bug notification because you are a member of FFC Core
>> Team, which is subscribed to FFC.
>> https://bugs.launchpad.net/bugs/600131
>>
>> Title:
>> regression tests do not use optimisation
>>
>> Status in FEniCS Form Compiler:
>> Fix Committed
>>
>> Bug description:
>> The regression test do not test with optimisations. They should test
>> both with and without optimisation (-O flag). Bugs have been
>> introduced unnoticed because of this,
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/ffc/+bug/600131/+subscriptions
>>