Launchpad itself

Can't delete team with superteams

Bug #599464 reported by Ahmed Shams
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Unassigned
Launchpad itself 10.11 "Tenacious Turkey"

Bug Description

I can't delete the team (team1) which I have made, Because another team (team2) had joined the team1 then team2 deleted by it's Admin, now I can't delete team1.

team1 (my team) is https://launchpad.net/~oss-translators
team2 is https://launchpad.net/~ubuntu-press-team-merged
I am https://launchpad.net/~akshams

Related branches

lp:~sinzui/launchpad/delete-team-3
Henning Eggers (community): Approve (code)
Diff: 788 lines (+227/-207)
10 files modified
lib/lp/registry/browser/peoplemerge.py (+37/-8)
lib/lp/registry/browser/team.py (+7/-9)
lib/lp/registry/browser/tests/mailinglist-views.txt (+6/-8)
lib/lp/registry/browser/tests/peoplemerge-views.txt (+2/-28)
lib/lp/registry/browser/tests/test_peoplemerge.py (+62/-1)
lib/lp/registry/interfaces/person.py (+21/-8)
lib/lp/registry/model/person.py (+23/-11)
lib/lp/registry/stories/mailinglists/lifecycle.txt (+14/-125)
lib/lp/registry/templates/team-delete.pt (+2/-2)
lib/lp/registry/tests/test_teammembership.py (+53/-7)
Curtis Hovey (sinzui)
affects: launchpad → launchpad-registry
Changed in launchpad-registry:
status: New → Incomplete
Revision history for this message
Curtis Hovey (sinzui) wrote :

I do not think ~ubuntu-press-team-merged is an issue here.

The error mesage for https://launchpad.net/~oss-translators is
    oss-translators has super teams, so it can't be merged.

The team must leave these teams first:
    https://launchpad.net/~oss-translators/+participation

I removed you from ~launchpad-users since I am am a team admin.

Revision history for this message
Diogo Matsubara (matsubara) wrote :

Ahmed emailed feedback@ explaining that he got OOPS-1637E1113 deleting ~ubuntu-press-team-merged from the ~oss-translators.

Revision history for this message
Curtis Hovey (sinzui) wrote :

The code doing the delete action is *thinks* it is doing a merge action. Merge cannot handle super teams because there is a chance that a cyclic team member error will occur. But since delete removes the team members, there is never any chance of a cyclic error. Actually, the delete step should remove the team from the super teams immediately after the membership is removed.

summary: - Can't delete my team
+ Can't delete team with superteams
Changed in launchpad-registry:
status: Incomplete → Triaged
importance: Undecided → Low
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: none → 10.11
assignee: nobody → Curtis Hovey (sinzui)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r11858 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11858>.

tags: added: qa-needstesting
Changed in launchpad-registry:
status: In Progress → Fix Committed
Revision history for this message
Curtis Hovey (sinzui) wrote :

I deleted ~oss-translators testing this fix. The problem was indeed that the team was not removed super teams.

tags: added: qa-ok
removed: qa-needstesting
Robert Collins (lifeless)
Changed in launchpad-registry:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in launchpad:
assignee: Curtis Hovey (sinzui) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.