code imports break when tdb is installed
Bug #599397 reported by
Aaron Bentley
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar Hg Plugin |
Fix Released
|
Low
|
Jelmer Vernooij | ||
| Launchpad itself |
Fix Released
|
Medium
|
Jelmer Vernooij | ||
Bug Description
Our code assumes that the import process emits a file named hg-v2.db, but this is only true for sqlite imports. If the python tdb package is installed, a different file is created. This breaks our code.
<abentley> jelmer, should we fix this by forcing sqlite or by installing tdb?
<jelmer> abentley: installing tdb in production is probably harder (more than a trivial code change in Launchpad), but will avoid some locking errors for bzr-svn imports and performs better
Related branches
lp:bzr-hg
- Launchpad code reviewers from Canonical: Pending requested
-
Diff: 729 lines (+257/-65)17 files modifiedMakefile (+3/-11)
NEWS (+21/-1)
README (+12/-0)
__init__.py (+48/-7)
branch.py (+19/-10)
commands.py (+55/-0)
fetch.py (+6/-4)
idmap.py (+2/-2)
info.py (+2/-2)
mapping.py (+8/-4)
parsers.py (+8/-5)
repository.py (+6/-1)
setup.py (+1/-1)
tests/__init__.py (+9/-2)
tests/test_dir.py (+42/-0)
tests/test_mapping.py (+1/-1)
tests/test_parsers.py (+14/-14)
lp:~jelmer/launchpad/update-bzr-hg
- Tim Penhey (community): Approve
- Steve Kowalik (community): Approve (code*)
-
Diff: 96 lines (+24/-13)4 files modifiedlib/lp/codehosting/codeimport/tests/servers.py (+1/-1)
lib/lp/codehosting/codeimport/worker.py (+21/-10)
utilities/sourcedeps.conf (+1/-1)
versions.cfg (+1/-1)
Revision history for this message
| Aaron Bentley (abentley) wrote | #1 |
Revision history for this message
| Jelmer Vernooij (jelmer) wrote | #2 |
| Changed in bzr-hg: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #3 |
| Changed in launchpad-code: | |
| assignee: | nobody → Jelmer Vernooij (jelmer) |
| milestone: | none → 10.09 |
| tags: | added: qa-needstesting |
| Changed in launchpad-code: | |
| status: | Triaged → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
| Changed in bzr-hg: | |
| status: | Triaged → Fix Committed |
| assignee: | nobody → Jelmer Vernooij (jelmer) |
| Changed in bzr-hg: | |
| milestone: | none → 0.2 |
| Changed in bzr-hg: | |
| status: | Fix Committed → Fix Released |
| milestone: | 0.2 → 0.1.1 |
To post a comment you must log in.
bzr-git now stores its cache in .bzr/repository/git - that can either be a sqlite file or a tdb file or <file-in-
bzr-hg needs to be updated to use the same directory structure.