HTTPResponse not using accumulated headers correctly

[Nathan Van Gheem]

In testing Zope 2.13.0a1, I noticed an issue when attempting to upgrade a plone 3.3.5 site.

In the file, ZServer/HTTPResponse.py there is the line

>>> headers = headers.items()
>>> for line in self.accumulated_headers:
>>> if line[0] == '\t':
>>> headers[-1][1] += '\n' + line
>>> continue
>>> headers.append(line.split(': ', 1))

The problem is that accumulated_headers is a tuple of name, values for the headers. So this sort of thing should actually be,

>>> headers = headers.items()
>>> headers.extend(self.accumulated_headers)

Before testing the upgrade, the site worked fine. It must be that the accumulated_headers is not used often and the bug just never surfaced. Perhaps I could be missing something though.

[Hanno Schlichting (hannosch)]

Tres, was this part of your cleanup?

[Nathan Van Gheem (vangheem)]

fixed in r115436