Optimise maybeWarnDeprecated

[Christian Zagrodnick]

OFS.subscriber.maybeWarnDeprecated checks if a deprecation warning should be sent.

There are two ways for classes to avoid the warning: ZCML and the __five_method__ attribute on the method.

maybeWarnDeprecated first checks the ZCML registered classes by iterating over a list:

    for cls in deprecatedManageAddDeleteClasses:
        if isinstance(ob, cls):
            # Already deprecated through zcml
            return

and then checking for __five_method__:

    if getattr(getattr(ob, method_name), '__five_method__', False):
        # Method knows it's deprecated
        return

IMHO those two checks should be reversed: first check for the attribute, then for the ZCML registered: checking for the attribute is *much* faster and is hit by common cases where a class is just subclassing an OFS.ObjectManager.ObjectManager.

(I noticed that during test setup where various DirectoryViews are created; the run time drops from 180s to 2s)

Anyone seconding that?

[Hanno Schlichting (hannosch)]

Sounds good to me. Maybe adding a first path for checking direct types without subtypes could help as well, something like:

ob_type = type(ob)
if ob_type in deprecatedManageAddDeleteClasses:
    return

for cls in deprecatedManageAddDeleteClasses:
    if issubclass(ob_type, cls):
        return

[Christian Zagrodnick (zagy)]

Sounds good. I'll do that :)

[Christian Zagrodnick (zagy)]

2.12 r113793

[Christian Zagrodnick (zagy)]

trunk r113794