[5.0] stock module contains references to purchase (but does not depend on it)

[Dukai Gábor]

Hi!
5.0 latest bzr.
Checking for a field with hasattr() doesn't work because browse_record intercepts that call and always returns True. If the field doesn't exist, it prints a 'Programming Error' message in the log but still returns True.

The stock module is affected by this problem. How to check: install only the stock module and use the partial picking wizard with average price products.
This code in stock/wizard/wizard_partial_picking.py gives a 'Programming Error':
            if hasattr(m, 'purchase_line_id') and m.purchase_line_id:

[Olivier Dony (Odoo) (odo-openerp)]

Regardless of the behavior of browse_record (which at first look in the code should not have hasattr() always returning True), this code is not correct as it break modularity. Installing stock without purchase is a valid case, and 'stock' should simply not have any reference to 'purchase' stuff *at all*.
This has been fixed in 6.0, and we should look into backporting it to stable (code related to purchase_line_id should move to purchase module)

Jay, do you think this qualifies for stable?

[Olivier Dony (Odoo) (odo-openerp)]

We can't touch such things in the server in a stable version, so closing the server side (from the original bug description) - this can be fixed in addons only

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello,

Backporting all the changes in stable is not really advisable here.
However, blocking the ugly traceback of Programming error is one the preferred solutions here.

Thanks.

[Dhruti Shastri(OpenERP) (dhs-openerp)]

Hello Dukai Gábor,

I followed your steps and met with an error.

Actually,it is an unreliability of hasattr.

Here I am attaching patch.

Would you please check with the attached patch and notify me?

Thanks.

[Olivier Dony (Odoo) (odo-openerp)]

@Jay: you're right, fixing it that way is probably safer for stable. Go for it!

[Olivier Dony (Odoo) (odo-openerp)]

@DHS: your patch is ok for me, forgot to mention it :-)

[Jay Vora (Serpent Consulting Services) (jayvora)]

Thanks Olivier and DHS,
The fix has been applied by revision 2886 <email address hidden>.