max_num_recipients is out by 1

[Terry Speirs]

I'm using mailman 2.1.12.cp3 and I notice that if I set max_num_recipients to say "2", then send an email to the list and one other address, then it bounces with a message which includes "Too many recipients to the message", and the moderator needs to release it, even though there were only 2 recipients. If I send the message in the same way, with max_num_recipients set to "3", then the message goes through fine.

It seems to me that, instead of max_num_recipients being the "Ceiling on acceptable number of recipients for a posting", it is more like the "point at which messages will not be accepted", and (max_num_recipients + 1) is the ceiling.

I recommend the calculation be changed. Failing that, the variable name and its description should be changed.

Thanks for your excellent software!

[Mark Sapiro (msapiro)]

Did you read the documentation at the "(Details for max_num_recipients)" link where it says "If a posting has this number, or more, of recipients, it is held for admin approval. Use 0 for no ceiling."?

Granted it's probably a bad design, but the documentation correctly describes how it works.