Replace updateTranslation calls with addSuggestion
Bug #595925 reported by
Henning Eggers
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Henning Eggers | ||
Bug Description
Now that we have addSuggestion we can make use of them by replacing any appropriate occurrence of updateTranslation with addSuggestion.
Related branches
lp:~henninge/launchpad/bug-595925-second-attempt
- Jeroen T. Vermeulen (community): Approve (code)
-
Diff: 1856 lines (+498/-406)12 files modifiedlib/lp/testing/factory.py (+37/-2)
lib/lp/translations/browser/tests/test_pofile_view.py (+2/-8)
lib/lp/translations/browser/tests/test_translationmessage_view.py (+14/-7)
lib/lp/translations/browser/translationmessage.py (+3/-7)
lib/lp/translations/tests/test_pofile.py (+342/-299)
lib/lp/translations/tests/test_potmsgset.py (+49/-54)
lib/lp/translations/tests/test_translatablemessage.py (+16/-12)
lib/lp/translations/tests/test_translations_to_review.py (+4/-2)
lib/lp/translations/utilities/sanitize.py (+4/-3)
lib/lp/translations/utilities/tests/test_sanitize.py (+19/-6)
lib/lp/translations/utilities/tests/test_superfastimports.py (+2/-2)
lib/lp/translations/windmill/tests/test_pofile_translate.py (+6/-4)
| Changed in rosetta: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| Changed in rosetta: | |
| assignee: | nobody → Henning Eggers (henninge) |
| status: | Triaged → In Progress |
| milestone: | none → 10.06 |
| Changed in rosetta: | |
| milestone: | 10.07 → 10.08 |
| Changed in rosetta: | |
| milestone: | 10.08 → none |
| Changed in rosetta: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Curtis Hovey (sinzui) wrote | #1 |
| tags: | added: upstream |
| tags: |
added: upstream-translations-sharing removed: upstream |
| Changed in launchpad: | |
| milestone: | none → 11.01 |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
If this is fix committed, shouldn't the milestone be 10.10?