Sabayon-apply fails on mozilla_bookmarks

[Erik Meitner]

Binary package hint: sabayon

After developing a new Sabayon profile and applying it to users:
1. log in as new user
2. alter Firefox bookmarks.
3. logout
4. login again
5. See that sabayon-apply fails part way through sometimes leaving the user session in an unusable state(no panels). Other times the users theme is reset to the current default for 10.04.

I have reproduced this numerous times.

Applying this patch solves the problem:
http://git.gnome.org/browse/sabayon/commit/?id=196b3fc3df775ea16c56ce4fb15021402101135e

It applies cleanly to the sabayon 2.29.5-0ubuntu1.

Errors from .xsession-errors:
MainThread 2010/06/17 12:36:22.2012 (sabayon-apply): Applying profile '/etc/sabayon/profiles/wsgc.zip' for user 'guest'
MainThread 2010/06/17 12:36:22.4284 (sabayon-apply): Fatal exception! Exiting abnormally.
MainThread 2010/06/17 12:36:22.4331 (sabayon-apply): Traceback (most recent call last):
  File "/usr/sbin/sabayon-apply", line 143, in <module>
    profile.apply (is_sabayon_session)
  File "/usr/lib/pymodules/python2.6/sabayon/userprofile.py", line 392, in apply
    delegate.apply (is_sabayon_session)
  File "/usr/lib/pymodules/python2.6/sabayon/sources/mozillasource.py", line 472, in apply
    target_bookmark.read()
  File "/usr/lib/pymodules/python2.6/sabayon/sources/mozillasource.py", line 1012, in read
    self.parser.feed(fd.read())
  File "/usr/lib/python2.6/HTMLParser.py", line 108, in feed
    self.goahead(0)
  File "/usr/lib/python2.6/HTMLParser.py", line 150, in goahead
    k = self.parse_endtag(i)
  File "/usr/lib/python2.6/HTMLParser.py", line 316, in parse_endtag
    self.handle_endtag(tag.lower())
  File "/usr/lib/pymodules/python2.6/sabayon/mozilla_bookmarks.py", line 367, in handle_endtag
    assert tag == self.stack[-1].tag
AssertionError

===== BEGIN MILESTONES (/usr/sbin/sabayon-apply) =====
MainThread 2010/06/17 12:36:22.2012 (sabayon-apply): Applying profile '/etc/sabayon/profiles/wsgc.zip' for user 'guest'
MainThread 2010/06/17 12:36:22.4284 (sabayon-apply): Fatal exception! Exiting abnormally.
MainThread 2010/06/17 12:36:22.4331 (sabayon-apply): Traceback (most recent call last):
  File "/usr/sbin/sabayon-apply", line 143, in <module>
    profile.apply (is_sabayon_session)
  File "/usr/lib/pymodules/python2.6/sabayon/userprofile.py", line 392, in apply
    delegate.apply (is_sabayon_session)
  File "/usr/lib/pymodules/python2.6/sabayon/sources/mozillasource.py", line 472, in apply
    target_bookmark.read()
  File "/usr/lib/pymodules/python2.6/sabayon/sources/mozillasource.py", line 1012, in read
    self.parser.feed(fd.read())
  File "/usr/lib/python2.6/HTMLParser.py", line 108, in feed
    self.goahead(0)
  File "/usr/lib/python2.6/HTMLParser.py", line 150, in goahead
    k = self.parse_endtag(i)
  File "/usr/lib/python2.6/HTMLParser.py", line 316, in parse_endtag
    self.handle_endtag(tag.lower())
  File "/usr/lib/pymodules/python2.6/sabayon/mozilla_bookmarks.py", line 367, in handle_endtag
    assert tag == self.stack[-1].tag
AssertionError

===== END MILESTONES (/usr/sbin/sabayon-apply) =====
===== BEGIN RING BUFFER (/usr/sbin/sabayon-apply) =====
MainThread 2010/06/17 12:36:22.2012 (sabayon-apply): Applying profile '/etc/sabayon/profiles/wsgc.zip' for user 'guest'
MainThread 2010/06/17 12:36:22.4284 (sabayon-apply): Fatal exception! Exiting abnormally.
MainThread 2010/06/17 12:36:22.4331 (sabayon-apply): Traceback (most recent call last):
  File "/usr/sbin/sabayon-apply", line 143, in <module>
    profile.apply (is_sabayon_session)
  File "/usr/lib/pymodules/python2.6/sabayon/userprofile.py", line 392, in apply
    delegate.apply (is_sabayon_session)
  File "/usr/lib/pymodules/python2.6/sabayon/sources/mozillasource.py", line 472, in apply
    target_bookmark.read()
  File "/usr/lib/pymodules/python2.6/sabayon/sources/mozillasource.py", line 1012, in read
    self.parser.feed(fd.read())
  File "/usr/lib/python2.6/HTMLParser.py", line 108, in feed
    self.goahead(0)
  File "/usr/lib/python2.6/HTMLParser.py", line 150, in goahead
    k = self.parse_endtag(i)
  File "/usr/lib/python2.6/HTMLParser.py", line 316, in parse_endtag
    self.handle_endtag(tag.lower())
  File "/usr/lib/pymodules/python2.6/sabayon/mozilla_bookmarks.py", line 367, in handle_endtag
    assert tag == self.stack[-1].tag
AssertionError

===== END RING BUFFER (/usr/sbin/sabayon-apply) =====

[Erik Meitner (e.meitner)]

Attaching patch I used to fix problem. It applies cleanly to 2.29.5-0ubuntu1wsgc1.

[Daniel Holbach (dholbach)]

According to http://git.gnome.org/browse/sabayon/log/?ofs=50 this is part of 2.92.92, we're at 2.30.0 - so this is fixed. Thanks!