test failure: AssertionError: command ['st'] loaded forbidden modules ['bzrlib.remote', 'bzrlib.smart']

[Vincent Ladeuil]

Reproduced with ./bzr selftest tariff

[Robert Collins (lifeless)]

I really think plugins should be able to load what they need ;).

Anyhow, a lazy format loader is in loom trunk now.

[Martin Pool (mbp)]

On 21 June 2010 08:04, Robert Collins <email address hidden> wrote:
> I really think plugins should be able to load what they need ;).

If they are loading a module that we would normally not load then either:

1- they have a good reason and the test should not fail
2- the plugin is accidentally causing it to be loaded, the test should
fail, and the plugin author should fix it.

With the current tariff tests we've seen both cases a few times.

It might be nice to more cleanly accommodate #1 by saying "normally
foo should not be loaded, but if plugin bar is installed then it's
ok." We could simply put that logic into the test.

--
Martin