Client and Server error while removing phone from ubuntuone-preferences

[Roman Yepishev]

Latest OOPS-ID with such issue: 13424-1629appserverZeaJdHbIGAAIBEeBEbBaeJIGDdAGIfEHH23675.oops.bz2

Caused by:
api/urls.py: url(r'^1.0/devices/remove/phone/(?P<number>\w+)$', 'remove_phone'),

Which goes to:
api/views.py:def remove_phone(request):
----------------------------------^ missing number parameter

Which is invoked by ubuntuone-preferences:
def remove(self, button, kind, token):
        """
        Callback for the Remove button.

        Starts an async request to remove a device.
        """
        make_rest_request(url=('%sremove/%s/%s' % (self.base_url,
                                                   kind.lower(), token)),

After an attempt to remove the phone from ubuntuone-client the following is printed:
HTTP Error 500: INTERNAL SERVER ERROR
ERROR:ubuntuone-preferences:Invalid response getting devices list.

[Natalia Bidart (nataliabidart)]

Roman, can you please detail what work is needed on u1client side?

Thanks!

[Roman Yepishev (rye)]

Naty, ubuntuone-preferences should use some kind of identifier to remove the phone but I guess the server side should select the phone entry attached to the account and remove it since we support only one phone at a time.

[Natalia Bidart (nataliabidart)]

token is None since:

(10:02:34 AM) rye: nessita, ah, that.. client sends None instead of phone identifier but the trick is that server/client should agree on whether the identifier should be sent at all.
(10:04:52 AM) nessita: rye: client is sending None as device_id? hm...
(10:05:07 AM) rye: nessita, yes, since the rest api does not provide any device_id

[Martin Albisetti (beuno)]

Working around this issue on the server-side, defaulting to the device the user has registered if we get None.

[Natalia Bidart (nataliabidart)]

Calling the url

https://one.ubuntu.com/api/1.0/devices/remove/phone/50255

gave me a 500, with oops id

<!-- OOPS-ID-1813appserverZBcfEcCCGaeaBEcfbbbFDEDdDDEAEEdFb105139 -->

[Natalia Bidart (nataliabidart)]

Found the oops and reported a dedicated bug for it.

[Natalia Bidart (nataliabidart)]

Setting this bug as Invalid for ubuntuone-client since we're making the server more robust to handle the /None request.
New control panel will send the device id.