Fully support custom swatches in the Fill&Stroke dialog

[su_v]

Inkscape 0.47+devel r9495 on OS X 10.5.8

As of r9495 custom swatches can only be added through a modified version of the gradient editor called by using 'Add' in the context menu of the 'Auto' palette:

- Clicking the 'Swatch' button in the Fill&Stroke dialog just switches the fill to a regular linear gradient if the object has a solid fill or none at all.
- Editing the color of a solid swatch (defined earlier by using the 'Add' context menu entry of the 'Auto' palette) does work in the Fill&Stroke dialog and offers the same color choosers as when editing a 'Flat color' fill/stroke or the color of a gradient stop.

IMHO it is important to be able to do both - add and edit - of custom swatches from within the Stroke&Fill dialog without resorting to the palette and the gradient editor for adding.

missing feature:

- convert (selected) solid colors and gradients used in the current drawing into custom swatches (less a problem for solid swatches, but more so for gradients).

[jazzynico (jazzynico)]

Confirmed on Windows XP, Inkscape r9451.

[su_v (suv-lp)]

related follow-up report: bug #594443 “Custom gradient swatches”

[Jon A. Cruz (jon-joncruz)]

Convert popup menu implemented.

[Jon A. Cruz (jon-joncruz)]

Patch to fix gradient stops select or drag-n-droped with a swatch paint. Needs to go to the 0.48 branch.

[Jon A. Cruz (jon-joncruz)]

Applied

[jazzynico (jazzynico)]

This report is still in progress. Is there something else to be done?

[su_v (suv-lp)]

> Is there something else to be done?

>> - convert (selected) solid colors and gradients
>> used in the current drawing into custom swatches

Works as expected but with a minor regression in 0.48(+devel): when converting a solid fill into a swatch using the button in the Fill&Stroke dialog, the single-stop gradient is not hidden but should be (as is done when applying the same swatch later to other shapes/objects).

[su_v (suv-lp)]

oops - wrong quotation:

- >> - convert (selected) solid colors and gradients
- >> used in the current drawing into custom swatches

+ >> - Clicking the 'Swatch' button in the Fill&Stroke dialog

[Alex Valavanis (valavanisalex)]

Shifted the milestone as 0.48 has been released

[ScislaC (scislac)]

It appears that all of the functionality currently works in trunk, can we milestone for 0.49? I believe some of why it works is actually due to changes that John Smith has made in the F&S dialog, so I don't know that backporting will be a smart thing to do.

[su_v (suv-lp)]

AFAICT most of the changes in the patch attached to comment #4 had already been committed to the 0.48.x branch at that time:
r9606 - Stop setting of stops from getting url() reference colors. (2010-07-11)
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/RELEASE_0_48_BRANCH/revision/9606>
r9618 - Follow-up to complete fix for gradient stops and icc. (2010-07-18)
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/RELEASE_0_48_BRANCH/revision/9618>

(Caveat: It's not possible for me to figure out what accounts for the few differences between the patch attached here and what was backported and committed to lp:inkscape/0.48.x at the time).

Remaining issue in 0.48.x and trunk (r11535) from comment #7:
«when converting a solid fill into a swatch using the button in the Fill&Stroke dialog, the single-stop gradient is not hidden but should be (as is done when applying the same swatch later to other shapes/objects).»

There's an additional variant of the above in 0.48.x and trunk (r11535):
If assigning a solid swatch color from the list of available swatches in Fill&Stroke, the handles of a tiny gradient are displayed at the SVG origin (gradient stops at (0,0) and (1,0). This does not happen when applying the custom swatch via 'Auto-Palette'.

Since these "remaining issues" are minor and not directly related to the original report (full support for custom swatches in 'Fill&Stroke'), they can be tracked in newer reports (focused on current trunk).

-> closing this report as 'Fix Released' for milestone 0.48 (Inkscape 0.48 r9654).

Please reopen if you think it was closed in error.