Hotkey to show/hide clearance

[hauptmech]

Hotkey switches between showing all clearances, and the previous state (ie show with new track/via, etc)

[hauptmech (hauptmech-users)]

The file clearance_display.patch was added: None

[Stephen Eaton (seaton)]

Oriiginally imported from sourceforge

Marking as triaged as patch attached - Will let development team decide if this can be closed

[John Beard (john-j-beard)]

Here is a new version of this patch with a slightly different implementation. Instead of using a static "last used" variable in PCB_EDIT_FRAME::OnHotKey, I added an "override" boolean to the DisplayOpts, alongside the existing mode enum. The hotkey then toggles this. If clearances are not currently "always on", the override being set shows them, otherwise an override acts to hide them. This way, the hotkey always effects a change to clearance display, but never replaces the users actual mode that they set in the Display... dialogue: that will always be what pressing 'Q' again returns to.

OK'ing the Display dialogue clears the override so that the user immediately sees what they had set in that dialogue. This is a part I am not totally sure about the best UI decision. Short of having a toolbar on/off button that you can click and that echoes the override when set by hotkey, I think this is clearest?

As an example, imagine clearances are currently "all off".

* Hotkey Q:override set, clearances displayed (user setting still "off")
* Use setting changed in the Display... dialogue to "always on" - override cleared, clearances displayed
* Hotkey Q:override set, clearances hidden (user setting still "on")
* Hotkey Q:override unset, clearances displayed according to user setting "on
* Hotkey Q:override set, clearances hidden (user setting still "on")
* Use setting changed in the Display... dialogue to "shown for new" - override cleared, clearances hidden, except for new tracks
* Hotkey Q:override set, clearances displayed (user setting still "only new")
* Hotkey Q:override unset, only new clearances displayed

Only the user-set mode is saved to the configs, the override is initialised to unset.