Bazaar

InterToBranch5 not used?

Bug #593515 reported by Robert Collins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
High
Robert Collins
Bazaar 2.2b4

Bug Description

bzrlib.branch.InterToBranch5 is either always being used, or never being used because it defines no is_compatible method, and derives from GenericInterBranch.

Assigning to Jelmer who introduced this to get his thoughts.

Revision history for this message
Robert Collins (lifeless) wrote :

Totally broken, and its broken hook behaviour too.

Changed in bzr:
assignee: Jelmer Vernooij (jelmer) → Robert Collins (lifeless)
importance: Medium → High
Revision history for this message
Robert Collins (lifeless) wrote :

Oh and uggggh.

The old arrangement was
Branch5
BranchesThatCanBeBound

but the new class arrangement is
BranchesThatCanBeBound
BranchesThatCan't

But the bound code path wants to use the unbound code path. I'm just going to delete the separate inter and make a helper function; we've already shuffled things suffiicently much that any compatability issues are gone.

Revision history for this message
Robert Collins (lifeless) wrote :

(The only reason I can see to keep InterToBranch5 around is to test that code path, but the tests added with branch inter's *didn't* add tests for that anyway, so its no worse to just remove the object).

Robert Collins (lifeless)
Changed in bzr:
status: Confirmed → Fix Released
milestone: none → 2.2b4
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.