scons doesnt detect missing libfaad library

[Owen Bullock]

I'm compiling trunk on Debian Linux. I didn't have the libfaad-dev package installed, theres a check for this in the SConscript file, but its broken and doesnt warn you. Instead it attempts to compile and soundsourcem4a.cpp fails due to a missing header.

Looks like this area of the SConscript has been worked on recently, to provide compatility with versions 2.6 and 2.7 of libfaad. I think as a result of this, the basic check for the library has got broken.

Patch attached, compilation tested successfully against both libfaad 2.6 and 2.7 versions

[RJ Skerry-Ryan (rryan)]

Thanks for the patch Owen, I committed it to our 1.8.x release branch.

[RJ Skerry-Ryan (rryan)]

Added you to the contributor list as Owen Bullock. Please let me know if you'd like to be credited under a different name :).

[Albert Santoni (gamegod)]

This broke my build on Ubuntu 8.10. In my case, the solution is probably to fix our SConscript so it doesn't run configure checks before running targets. In other words, I don't want "scons makeubuntu" to check for ANY dependencies, because it ends up building inside a different (chrooted pbuilder) environment.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5418