Check catalog performance during imagedrawer image upload operation

Bug #592697 reported by Balazs Ree
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KARL3
Fix Released
Low
Tres Seaver

Bug Description

When an image is uploaded with the imagedrawer, in order to maximize performance we want to make sure that the newly created image is cataloged once only: ie, there are no subsequent recatalog operations within the same request.

If we want to be sure about this we need a way to check this. Best would be to have a unittest that checks this, but a one time check would be fine too.

If there are more recatalog operations for some inherent reason, I believe we can live with that but we should be aware.

Revision history for this message
Paul Everitt (paul-agendaless) wrote :

We'll see if Chris can look at this in the next milestone after this one.

Changed in karl3:
assignee: nobody → Chris Rossi (chris-archimedeanco)
importance: Undecided → Low
milestone: none → m43
Changed in karl3:
milestone: m43 → m44
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Handing some things over to Tres.

Changed in karl3:
assignee: Chris Rossi (chris-archimedeanco) → Tres Seaver (tseaver)
Revision history for this message
Tres Seaver (tseaver) wrote :

Any extraneous indexing would be happening as the images are added / removed
from the tempfolder: I can see no valid case for having content which is in that
folder be indexed at all.

Suppressing the unwanted index / unindex should be as simple as overriding
the 'add' and 'remove' methods on karl.models.tempfolder.TempFolder, making the
'send_events' default to False. Plus testing for the non-publication of the events,
of course.

Changed in karl3:
status: New → In Progress
Revision history for this message
Tres Seaver (tseaver) wrote :

Fix committed, with tests, on a branch:

 svn+ssh://<email address hidden>/home/osi/bfgsvn/karl/branches/lp592697

Changed in karl3:
status: In Progress → Fix Committed
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Got done in M43.

Changed in karl3:
milestone: m44 → m43
Revision history for this message
Tres Seaver (tseaver) wrote :

I just merged the branch to the trunk.

Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Not really testable, I'll go ahead and mark as done.

Changed in karl3:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.